? Success

User tests: Successful: Unsuccessful:

avatar khoaredweb
khoaredweb
14 Mar 2016

Summary of Changes
Add the $_type = "html" before get renderer class to make sure no error "Unable to load renderer class" if url request the return format != html
Testing Instructions
I got the error when developing a plugin for calling from com_ajax

avatar khoaredweb khoaredweb - open - 14 Mar 2016
avatar khoaredweb khoaredweb - change - 14 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Mar 2016
Title
Fix error unable to load renderer class if request params include format <> html
Fix error unable to load renderer class if request params include format html
Labels Added: ? ?
avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Mar 2016

Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks.
This is an automated message from the J!Tracker Application.

avatar brianteeman brianteeman - change - 14 Mar 2016
Title
Fix error unable to load renderer class if request params include format <> html
Fix error unable to load renderer class if request params include format html
Labels Removed: ?
avatar mbabker
mbabker - comment - 14 Mar 2016

Not a good fix. If you've instantiated a JDocument object in a non-HTML format, you're doing a massive change to the internals here by changing that variable (imagine if you will a JDocumentJson object that you've now set the internal type to HTML).

The correct action in all plugins that interact with output in any form is to check the environment and change the behavior based on that. If a plugin functionality relies on HTML output, this needs to be checked because the same behavior may cause issues with a JSON or XML document object (for example).

avatar khoaredweb khoaredweb - change - 15 Mar 2016
Title
Fix error unable to load renderer class if request params include format <> html
Fix error unable to load renderer class if request params include format html
avatar brianteeman brianteeman - change - 17 Mar 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-03-17 19:40:28
Closed_By brianteeman
avatar brianteeman
brianteeman - comment - 17 Mar 2016

Closed


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9417.

avatar brianteeman brianteeman - close - 17 Mar 2016
avatar brianteeman brianteeman - change - 17 Mar 2016
Title
Fix error unable to load renderer class if request params include format <> html
Fix error unable to load renderer class if request params include format html
avatar brianteeman brianteeman - close - 17 Mar 2016

Add a Comment

Login with GitHub to post a comment