? ? Pending

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
12 Mar 2016

Summary of Changes

This PR adds a new column "Secure" in updates sites list view to inform the user if the update site use secure https connection or not.

image

Testing Instructions

  1. Install the patch
  2. Check if "http:" urls are marked as "No" in the new column and the "https:" url are marked as "Yes". Check the tooltip in the "No" too.
  3. Finally check if the ordering of the "Secure" column works in several languages.
avatar andrepereiradasilva andrepereiradasilva - open - 12 Mar 2016
avatar andrepereiradasilva andrepereiradasilva - change - 12 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Mar 2016
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 12 Mar 2016

Not sure I agree with this one.

  1. Saying something is not secure might put people off using it

  2. The XML might be http but the file might be https
    On 12 Mar 2016 5:34 pm, "andrepereiradasilva" notifications@github.com
    wrote:

Summary of Changes

This PR adds a new column "Secure" in updates sites list view to inform
the user if the update site use secure https connection or not.

[image: image]
https://cloud.githubusercontent.com/assets/9630530/13724268/6b024bea-e878-11e5-85cd-0164f3ac5476.png
Testing Instructions

  1. Install the patch
  2. Check if "http:" urls are marked as "No" in the new column and the "https:" url are marked as "Yes". Check the tooltip in the "No" too.
  3. Finally check if the ordering of the "Secure" column works in several languages.

You can view, comment on, or merge this pull request online at:

#9389
Commit Summary

  • promote the use of HTTPS in update sites list view
  • remove duplicated client_id

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#9389.

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Mar 2016
  1. Saying something is not secure might put people off using it

Yes i understand that.

  1. The XML might be http but the file might be https

Yes unfortunately you're right...
To check that we would have to check all urls in the update, so i will close this PR.

avatar andrepereiradasilva andrepereiradasilva - change - 12 Mar 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-03-12 17:45:26
Closed_By andrepereiradasilva

Add a Comment

Login with GitHub to post a comment