? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
12 Mar 2016

Summary of Changes

This PR changes all http:// URI in language ini files that use sites exclusive in HTTPS to https://

Testing Instructions

Check code difference.

avatar andrepereiradasilva andrepereiradasilva - open - 12 Mar 2016
avatar andrepereiradasilva andrepereiradasilva - change - 12 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Mar 2016
Labels Added: ? ?
avatar brianteeman brianteeman - change - 12 Mar 2016
Milestone Added:
avatar brianteeman
brianteeman - comment - 12 Mar 2016

Not going to comment everywhere but please use QQ for links eg
< a href="_QQ_"https://www.google.com/recaptcha"_QQ_" target="_QQ_"_blank"_QQ_">

avatar brianteeman
brianteeman - comment - 12 Mar 2016

Also you have changed some urls in tooltips to links. No point in doing that as you cannot click on a tooltip ;)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9386.

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Mar 2016

@brianteeman what tooltips?
Also, why use "_QQ_" instead of just '. Can you explain me the reason for that? Just asking to understand.

avatar brianteeman
brianteeman - comment - 12 Mar 2016

If a string ends _DESC and is not a .sys.ini file then it is a tooltip

Really dont want to go into the long stupid story about QQ but you need to do that

avatar mbabker
mbabker - comment - 12 Mar 2016

Didn't we agree already to deprecate "_QQ_" or am I back in wishful thinking land?

avatar brianteeman
brianteeman - comment - 12 Mar 2016

@mbabker we did but then it broke com_localise and I lost the will to argue and dont have it back

avatar brianteeman brianteeman - change - 12 Mar 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-03-12 17:04:38
Closed_By brianteeman
avatar brianteeman brianteeman - close - 12 Mar 2016
avatar brianteeman brianteeman - change - 12 Mar 2016
Status Closed New
Closed_Date 2016-03-12 17:04:38
Closed_By brianteeman
avatar brianteeman brianteeman - change - 12 Mar 2016
Status New Pending
avatar brianteeman brianteeman - reopen - 12 Mar 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Mar 2016

ok i will put the QQ, when deprecated we can remove all of then at once.
ok for the tooptip (there is one i changed)

avatar mbabker
mbabker - comment - 12 Mar 2016

It only breaks if you don't have the slightest clue how to correctly escape quotes in strings. But alas. Removing it one day is a B/C break, and heaven forbid anyone EVER break B/C short of a security issue (I've been reading too much PHP internals lately).

avatar brianteeman
brianteeman - comment - 12 Mar 2016

Lets not get distracted by useless conversations ;)

On 12 March 2016 at 17:06, Michael Babker notifications@github.com wrote:

It only breaks if you don't have the slightest clue how to correctly
escape quotes in strings. But alas. Removing it one day is a B/C break, and
heaven forbid anyone EVER break B/C short of a security issue (I've been
reading too much PHP internals lately).


Reply to this email directly or view it on GitHub
#9386 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Mar 2016

O_qq_ now?

avatar brianteeman
brianteeman - comment - 12 Mar 2016

I wish you had just changed the protocol and didnt change anything else but you have added target=blank to everything which is considered to be bad practice for accessibility and turned things that were not links into links - I assume there was a reason that they were not links before so now need to be reviewed

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Mar 2016

ok i will remove the target=_blank...

reggarding the links i just added then in the XML description... that i know of there is no problem with that.

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Mar 2016

@brianteeman can/should the *.sys.ini files have links?
If not i will remove the ones i added in those files.

avatar brianteeman
brianteeman - comment - 12 Mar 2016

Yes but I'm not sure if they were not made as links for a specific reason
or just an errror
On 12 Mar 2016 8:15 pm, "andrepereiradasilva" notifications@github.com
wrote:

ok i will remove the target=_blank...

reggarding the links i just added then in the XML description... that i
know of there is no problem with that.


Reply to this email directly or view it on GitHub
#9386 (comment).

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Mar 2016
avatar infograf768
infograf768 - comment - 13 Mar 2016

I would not touch the targets at all or clickable/non clickable nature of the urls.
The only change imho should be the http =>https when necessary.

avatar andrepereiradasilva
andrepereiradasilva - comment - 13 Mar 2016

ok. will remove all changes except the https ones.

avatar andrepereiradasilva
andrepereiradasilva - comment - 13 Mar 2016

ok. now only http to https please check

avatar brianteeman brianteeman - test_item - 13 Mar 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 13 Mar 2016

I have tested this item :white_check_mark: successfully on e9c2680


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9386.

avatar brianteeman
brianteeman - comment - 13 Mar 2016

Thank you


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9386.

avatar zero-24 zero-24 - test_item - 13 Mar 2016 - Tested successfully
avatar zero-24
zero-24 - comment - 13 Mar 2016

I have tested this item :white_check_mark: successfully on e9c2680

simple fix. thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9386.

avatar brianteeman brianteeman - change - 13 Mar 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 13 Mar 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9386.

avatar joomla-cms-bot joomla-cms-bot - change - 13 Mar 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Added:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Added:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 22 Mar 2016
Category Language & Strings
avatar brianteeman brianteeman - change - 22 Mar 2016
Labels
avatar rdeutz rdeutz - change - 12 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-12 19:41:06
Closed_By rdeutz
Labels
avatar rdeutz rdeutz - reference | 99045ac - 12 Apr 16
avatar rdeutz rdeutz - merge - 12 Apr 2016
avatar rdeutz rdeutz - close - 12 Apr 2016
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 12 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment