User tests: Successful: Unsuccessful:
This PR changes all http:// URI in language ini files that use sites exclusive in HTTPS to https://
Check code difference.
Status | New | ⇒ | Pending |
Labels |
Added:
?
?
|
Milestone |
Added: |
Also you have changed some urls in tooltips to links. No point in doing that as you cannot click on a tooltip ;)
@brianteeman what tooltips?
Also, why use "_QQ_"
instead of just '
. Can you explain me the reason for that? Just asking to understand.
If a string ends _DESC and is not a .sys.ini file then it is a tooltip
Really dont want to go into the long stupid story about QQ but you need to do that
Didn't we agree already to deprecate "_QQ_"
or am I back in wishful thinking land?
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-12 17:04:38 |
Closed_By | ⇒ | brianteeman |
Status | Closed | ⇒ | New |
Closed_Date | 2016-03-12 17:04:38 | ⇒ | |
Closed_By | brianteeman | ⇒ |
Status | New | ⇒ | Pending |
ok i will put the QQ, when deprecated we can remove all of then at once.
ok for the tooptip (there is one i changed)
It only breaks if you don't have the slightest clue how to correctly escape quotes in strings. But alas. Removing it one day is a B/C break, and heaven forbid anyone EVER break B/C short of a security issue (I've been reading too much PHP internals lately).
Lets not get distracted by useless conversations ;)
On 12 March 2016 at 17:06, Michael Babker notifications@github.com wrote:
It only breaks if you don't have the slightest clue how to correctly
escape quotes in strings. But alas. Removing it one day is a B/C break, and
heaven forbid anyone EVER break B/C short of a security issue (I've been
reading too much PHP internals lately).—
Reply to this email directly or view it on GitHub
#9386 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
O_qq_ now?
I wish you had just changed the protocol and didnt change anything else but you have added target=blank to everything which is considered to be bad practice for accessibility and turned things that were not links into links - I assume there was a reason that they were not links before so now need to be reviewed
ok i will remove the target=_blank...
reggarding the links i just added then in the XML description... that i know of there is no problem with that.
@brianteeman can/should the *.sys.ini files have links?
If not i will remove the ones i added in those files.
Yes but I'm not sure if they were not made as links for a specific reason
or just an errror
On 12 Mar 2016 8:15 pm, "andrepereiradasilva" notifications@github.com
wrote:
ok i will remove the target=_blank...
reggarding the links i just added then in the XML description... that i
know of there is no problem with that.—
Reply to this email directly or view it on GitHub
#9386 (comment).
here we have target_blank and links in a sys.ini ...
https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.plg_authentication_gmail.sys.ini#L7
I would not touch the targets at all or clickable/non clickable nature of the urls.
The only change imho should be the http =>https when necessary.
ok. will remove all changes except the https ones.
ok. now only http to https please check
I have tested this item successfully on e9c2680
Thank you
I have tested this item successfully on e9c2680
simple fix. thanks
Status | Pending | ⇒ | Ready to Commit |
Labels |
Labels |
Added:
?
|
Milestone |
Removed: |
Milestone |
Added: |
Milestone |
Added: |
Milestone |
Removed: |
Category | ⇒ | Language & Strings |
Labels |
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-12 19:41:06 |
Closed_By | ⇒ | rdeutz | |
Labels |
Milestone |
Removed: |
Milestone |
Added: |
Milestone |
Added: |
Milestone |
Removed: |
Labels |
Removed:
?
|
Not going to comment everywhere but please use QQ for links eg
< a href="_QQ_"https://www.google.com/recaptcha"_QQ_" target="_QQ_"_blank"_QQ_">