?
Referenced as Pull Request for: # 9379
avatar brianteeman
brianteeman
10 Mar 2016

Steps to reproduce the issue

Joomla 3.5RC
In article manager select multiple articles and then batch
Hover over the two top items and you will see the tooltip is hidden below the title
screen shot 2016-03-10 at 10 06 13

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar brianteeman brianteeman - open - 10 Mar 2016
avatar brianteeman
brianteeman - comment - 10 Mar 2016

The same problem is true in the other batch views but I assume its the same code


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9363.

avatar muhakh
muhakh - comment - 10 Mar 2016

I don't have this problem
as
Version: Joomla! 3.4.8 Stable

avatar brianteeman
brianteeman - comment - 10 Mar 2016

@muhakh sorry if it wasnt clear - this is with 3.5rc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9363.

avatar brianteeman brianteeman - change - 10 Mar 2016
The description was changed
Build master 3.5rc
avatar MATsxm
MATsxm - comment - 10 Mar 2016

Able to reproduce on 3.5rc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9363.

avatar muhakh
muhakh - comment - 10 Mar 2016

I'm able to reproduce it too.

avatar andrepereiradasilva
andrepereiradasilva - comment - 10 Mar 2016

+1 reproducing it

avatar Bakual
Bakual - comment - 10 Mar 2016

It's caused by #9140

avatar Bakual
Bakual - comment - 10 Mar 2016

More specific that rule:

.modal-body {
    overflow-y: auto !important;
}
avatar brianteeman
brianteeman - comment - 10 Mar 2016

Which was the main role of that pr :(

avatar Bakual
Bakual - comment - 10 Mar 2016

Yeah, you can't have the tooltips go over the box (overflow:visible) and have the ability to scroll at the same time. It's either or.

avatar brianteeman brianteeman - change - 10 Mar 2016
Status New Needs Review
avatar brianteeman
brianteeman - comment - 10 Mar 2016

Setting to needs review so maintainer ( @wilsonge et al) can make a decision if the PR should be reverted


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9363.

avatar wilsonge
wilsonge - comment - 11 Mar 2016

What's the feeling here - which is least usable :(

avatar wilsonge wilsonge - change - 11 Mar 2016
Labels Added: ?
avatar Bakual
Bakual - comment - 11 Mar 2016

Personally I would revert that single rule.
Currently, the tooltips are useless on any device as they do not show.
When we revert, some modals become unusable for devices with very small screens. But honestly, when I tried with resizing the buttons became unusuable (below screen) before the body was to small. The scrolling didn't help there because the buttons stay below the screen. Thus I doubt that line really solves anything.
Also it shows ugly scroll bars for me even if the window is big enough to show everything.

avatar infograf768
infograf768 - comment - 11 Mar 2016

Taking off that rule does not solve the tooltips issue here.

avatar infograf768
infograf768 - comment - 11 Mar 2016

In fact, reverting all PR #9140 does not get the tooltips back here.
Macintosh, Firefox, Chrome, Safari

avatar Bakual
Bakual - comment - 11 Mar 2016

You're sure you cleared browser cache?

avatar infograf768
infograf768 - comment - 11 Mar 2016

tested on the 3 browsers, caches deleted indeed.

avatar Bakual
Bakual - comment - 11 Mar 2016

Strange.

avatar JoomliC
JoomliC - comment - 11 Mar 2016

I've created the PR to fix scrolling on webkit mobile browser to prevent a regression with new usage of BS modal to replace mootools old one.
The scrolling fix is not a nice hack but it's an known issue in BS2 and BS3 (due to webkit touch with no effect inside BS modals).

Great you've found this issue with tooltip, and thanks! (i didn't notice it when working on PR to fix scrolling).

I will open a PR to fix this tooltip issue in modals in arround 1 hour.

The reason is the layout language for batch, the container set for tooltip is wrong.
It is set to .modal-body, but should be set to .modal

Also it shows ugly scroll bars for me even if the window is big enough to show everything.

Not directly related to my PR on scoll fix, but to the padding set for modal-body.
Will try to fix it in the same time as fixing the tooltip. Your test would be welcome! ;-)

The scrolling didn't help there because the buttons stay below the screen. Thus I doubt that line really solves anything.

You mean resizing to a bery low height on a desktop device ?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9363.

avatar JoomliC JoomliC - reference | 69823d9 - 11 Mar 16
avatar JoomliC
JoomliC - comment - 11 Mar 2016

I have created the PR for tooltip fix in batch modal. #9379

@Bakual still working on a way to add scroll only when needed (but even if working well on desktop, still an issue on my iOS phone...) and not having to set the overflow-y: auto !important in css ;-)

I think we can close here, as a PR ;-)

avatar brianteeman
brianteeman - comment - 11 Mar 2016

Closed

avatar brianteeman brianteeman - change - 11 Mar 2016
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2016-03-11 22:16:31
Closed_By brianteeman
avatar brianteeman brianteeman - close - 11 Mar 2016
avatar wilsonge wilsonge - close - 11 Mar 2016
avatar brianteeman brianteeman - close - 11 Mar 2016
avatar wilsonge wilsonge - change - 12 Mar 2016
Labels Removed: ?
avatar infograf768
infograf768 - comment - 12 Mar 2016

@Bakual
Looks like I was testing on the wrong test site. Apologies.

Add a Comment

Login with GitHub to post a comment