[#9358] - Link the link in the search results
- Closed
- 7 May 2016
- Medium
- Build: staging
- # 9358
- Diff
- bembelimen:patch-14
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
The search results show a non clickable link, which confuses users
Testing Instructions
Create a finder menu link and search, there is a non clickable link at the bottom of every search result. Apply patch => link is clickable
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
I don't think, that it is a good idea to overwrite template defauls (= style of a link) by the component. If you do it black and someone has a black site with white text, it breaks.
| Category | ⇒ | Search |
well now i see how google does it, and it doesn't have link, so, maybe no link at all is better.
I have tested this item 
successfully on 1a8dbd3
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9358.
I have tested this item successfully on 1a8dbd3
The change works as proposed, having compared google and bing search neither have the links hyperlinked, both however have the link showing below the title... I guess it all depends on what way we want to go.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9358.
| Status | Pending | ⇒ | Needs Review |
Setting Needs Review so the maintainers can make a decision
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9358.
As the current behaviour matches that of major search engines I think our default behaviour should remain as it is. Anyone who wants something different can easily override it. Thanks for the suggestion and contributing the code, but this is not something that will be changed in the core.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9358.
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-05-07 14:48:34 |
| Closed_By | ⇒ | chrisdavenport |
Set to "closed" on behalf of @chrisdavenport by The JTracker Application at issues.joomla.org/joomla-cms/9358
This works fine, but IMHO the style of the text shouldn't change.
Before:
After:
