[#9341] - remove extra Tinymce code
- Closed
- 8 Mar 2016
- Medium
- Build: staging
- # 9341
- Diff
- brianteeman:tinymce-code
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # 9339.
Summary of Changes
Remove duplicated code icon
Testing Instructions
Check in the advanced AND extended modes of tinmyce and you will see two code icons. One after the image icon and one at the very end
This PR removes the second instance
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Category | ⇒ | Plugins |
| Title |
|
||||||
| Rel_Number | 0 | ⇒ | 9339 |
| Relation Type | ⇒ | Pull Request for |
I have tested this item 
unsuccessfully on 15a4c81
The PR solves the issue for extended funcionality, but in this way in Advanced funcionality there is no more <> button.
If you change just the line 890, then you'll have the expected result.
I would suggest not to put the code button at the end, but in the middle, in this way
toolbar1: \"$toolbar1 | code | $toolbar5 \",
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9341.
I have tested this item 
successfully on 15a4c81
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9341.
This PR has received new commits.
CC: @1apweb, @AlexRed, @stellainformatica
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9341.
I have tested this item successfully on 655d7fa
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9341.
I have tested this item successfully on 655d7fa
Tested in both advanced and extended mode that in both cases there is 1 icon "<>" for source code insert shown after the icon for image insert.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9341.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-08 22:13:27 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
| Milestone |
Added: |
||
Thanks Brian!
I have tested this item
successfully on 15a4c81
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9341.