?
avatar andrepereiradasilva
andrepereiradasilva
7 Mar 2016

Steps to reproduce the issue

Upgrade from 2.5.28 (clean install with sample data) to 3.5.0 beta 5 using custom URL: https://downloads.joomla.org/updates/cms/test/list_test_25to3x.xml.

Expected result

Joomla upgraded without issues.

Actual result

You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '--ALTER TABLE #__redirect_links MODIFY new_url varchar(255)' at line 5 SQL=-- -- The following statement has to be disabled because it conflicts with -- a later change added with Joomla! 3.5.0 for long URLs in this table -- --ALTER TABLE #__redirect_links MODIFY new_url varchar(255);

And joomla backend gets broken. 500 error on several backend pages after update.

System information (as much as possible)

Database Version: 5.5.5-10.0.24-MariaDB
PHP Version: 5.6.18

Additional comments

I think this only happens when upgrading from 3.3.6 or lower versions to 3.5.0 beta 4/5.

Maybe problem with sql comment (missing space after --)?

Can this also be the cause of the 500 error observed before on upgrade from lower versions?

@richard67 can you check this one?

avatar andrepereiradasilva andrepereiradasilva - open - 7 Mar 2016
avatar richard67
richard67 - comment - 7 Mar 2016

Yes, am just working on a PR to solve that. Of course I also could remove all comments from that sql update script, and hope we have no others with comments now and in future, but this would be the quck but not good solution.

avatar richard67
richard67 - comment - 7 Mar 2016

@andrepereiradasilva Can you test if my new PR #9332 solves your problem?

avatar andrepereiradasilva
andrepereiradasilva - comment - 7 Mar 2016

mantainers you can close this as we have a PR

avatar richard67
richard67 - comment - 7 Mar 2016

Yes. PR #9332 solves this problem here (not only for 2.5 but also for others, see comments there).


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9331.

avatar Bakual Bakual - change - 7 Mar 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-03-07 18:48:35
Closed_By Bakual
avatar Bakual Bakual - close - 7 Mar 2016
avatar brianteeman brianteeman - close - 7 Mar 2016
avatar brianteeman brianteeman - change - 8 Mar 2016
Labels Added: ?

Add a Comment

Login with GitHub to post a comment