[#9328] - Solves 9326: clean beta 4 install without pre-created database doesn't work
- Closed
- 7 Mar 2016
- Medium
- Build: staging
- # 9328
- Diff
- andrepereiradasilva:patch-2
- Success Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #9326 .
Summary of Changes
Solves #9326
Testing Instructions
- Use beta 4 or latest staging and proceed with clean joomla install
- Do step 1 of install
- Check code difference in this PR and change that file (/libraries/joomla/database/driver.php) before executing step 2 (database) of install.
- On step 2 of install enter a new database (don't use one that already exists). before this change it wouldn't work, after this change it will work.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
| Title |
|
||||||
| Title |
|
||||||
I have tested this item 
successfully on 7cacd55
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9328.
@andrepereiradasilva I just was testing new install for several db and php versions but could not confirm problems reported in issue #9326 yet. But in 1 case my server got extremely slow. Because I was dealing with this piece of code, too (also wanted to change it to support utf8mb4), I would say by code review that your change with this PR here corrects a bad mistake.
@wilsonge Should be merged by code review, it is obviosly correcting a bad mistake, no need to test that.
@richard67 it only happens when you create a new database on install on a utf8 capable server. If you use a database that already exists it works before this PR.
I could replicate the issue and the proposed fix solves it.
Also current code is obviously wrong as there is an undefined variable ($collation)
Yes, just got that after reading comments to the issue. I can test but would be nice if I could save the work because it gets merged before.
yeah sure
Well I start preparing the test ... is a bit uncomfortable because I test on remote shared host, not on local PC.
ahhh ... i cannot test this i am afraid ... will not have privileges maybe to create new db with Joomla! installation.
Maybe @stellainformatica can test?
I have tested this item successfully on 7cacd55
Ok, now I can install Joomla 3.5 beta4
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9328.
I have tested this item successfully on 7cacd55
Tested in localhost, it solves the issue I reported here https://issues.joomla.org/tracker/joomla-cms/9326
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9328.
@wilsonge Could be worth to make a Beta 5 just with this Patch included.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9328.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-07 13:18:38 |
| Closed_By | ⇒ | wilsonge |
I don't have the resources to release on laptop :(
On it. Expect everything to be published in next half hour.
Welcome back, my friend! :-)
Thank you!
Thanks so much michael!
@richard67 can you test this?