Feeling Lucky
?
[#9322] - Static method JURI/current changed to JURI/getInstance
- Fixed in Code Base
- 12 Apr 2016
- Medium
- Build: staging
- # 9322
- Diff
- GABBAR1947:staging
- Success The Travis CI build passed Details
Pull Request for
# 9321
User tests: Successful: Unsuccessful:
Summary of Changes
The 'current()' static method had to be changed as it returned the current request URI without the query parts or params. getInstance() does work for the situation.
Testing Instructions
Replace the static method in the codebase. Try editing any module and also set some parameters in dropdown menu's as well as in the text boxes. Now clicking on 'Back to top' link does not redirect to the home page as stated in the issue #9321 .
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
infograf768
- comment
- 7 Mar 2016
given the small change, I suppose it would be better.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-07 08:21:25 |
| Closed_By | ⇒ | GABBAR1947 |
| Status | Closed | ⇒ | New |
| Closed_Date | 2016-03-07 08:21:25 | ⇒ | |
| Closed_By | GABBAR1947 | ⇒ |
| Status | New | ⇒ | Pending |
infograf768
- comment
- 7 Mar 2016
For me it works for the "Back to Top" link but I wonder about other possible issues.
Would be good to test on other stuff.
brianteeman
- | Rel_Number | 0 | ⇒ | 9321 |
| Relation Type | ⇒ | Pull Request for |
| Category | ⇒ | Libraries |
rdeutz
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-12 19:37:17 |
| Closed_By | ⇒ | rdeutz |
The tests broke due to some other commits. Should I make a new PR?