[#9319] - The idea of having Search tools replaced by Filters.
- Closed
- 7 Apr 2016
- Medium
- Build: staging
- # 9319
- Diff
- shubhamnba2009:staging
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #9127 .
Summary of Changes
Made some changes regarding changing the name from search tools to filters.
Testing Instructions
1.Before applying the patch: Under article menu filtering the list item button is named as Search tools.
2.After applying patch: The button is renamed as Filters.
Votes
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
| Category | ⇒ | Language & Strings |
| Labels | |||
I have tested this item 
successfully on d1d4ab2
Tested succesfully
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9319.
| Rel_Number | 0 | ⇒ | 9127 |
| Relation Type | ⇒ | Pull Request for | |
| Labels | |||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Thanks pe7er and louiswolf for testing it.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9319.
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
This PR has received new commits.
CC: @louiswolf, @pe7er
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9319.
This PR has received new commits.
CC: @louiswolf, @pe7er
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9319.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-07 21:07:09 |
| Closed_By | ⇒ | shubhamnba2009 |
| Status | Closed | ⇒ | New |
| Closed_Date | 2016-04-07 21:07:09 | ⇒ | |
| Closed_By | shubhamnba2009 | ⇒ |
| Status | New | ⇒ | Pending |
I am opening a seperate pull request for this one. By mistake made commit to this branch.
| Labels |
Removed:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-07 21:30:11 |
| Closed_By | ⇒ | shubhamnba2009 |
I'm sorry to be about to say no successful test...
Changing name "Search Tools" to "Filters" is just a way to kill future possibilities (both Joomla and extensions developers) and to limit its usage.
The main intention of Search Tools button was too simplify UX.
A good PR to improve Search Tools would be IMHO to migrate search field and ordering/limit fields to the Search Tools button (all in one).
In fact, as it is the case directly above, in our loved Joomla! Issue Tracker! ;-)
Search field + Filters + List Ordering + List nb of items = Search Tools
That is said... i really and sincerely don't think this change to be a good idea...
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9319.
rdeutz
- | Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
@brianteeman @rdeutz please remove the milestone from that closed and not merged issue.
| Milestone |
Removed: |
||
Changing name "Search Tools" to "Filters" is just a way to kill future possibilities (both Joomla and extensions developers) and to limit its usage.
With all respect ... How is it even possible to conclude this way? Also it's not simplifying, if people don't understand where to look for the filters etc. ;)
If someone in future wants to extend/merge functions, please do, and then change the name to fit. It doesn't limit anyone to use a proper naming for the existing features in it.
But even if you merge features it would still not be just 'Search Tools', as you can do more with it than just searching. So when you merge features, feel free to rename it to 'Filters & Tools' or whatever. But for now it's just 'Filters' in there ...
#9127 (comment)
I am opening a seperate pull request for this one. By mistake made commit to this branch.
@shubhamnba2009 did you open a separate pull request for it, or was it forgotten? I don't find any references to it, thus asking.
Oh, btw!
I have tested this item
successfully on d1d4ab2
Test successful.
IMHO "Filters" is a better name for that button than "Search Tools".
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9319.