? Success
Pull Request for # 9186

User tests: Successful: Unsuccessful:

avatar corejoomla
corejoomla
6 Mar 2016

Pull Request for Issue # .

Summary of Changes

Fix for the issue #9186
Unable to add countItems method for an extension where the category
system is used in two instances #9186

Testing Instructions

Setup a component with two instances of the category. For example:

a. component com_mycomponent has two types of items type1 and type2
b. type1 uses Joomla category system with extension name as com_mycomponent
c. type2 uses Joomla category system with extension name as com_mycomponent.type2

countItems feature works for both categories instances.

avatar corejoomla corejoomla - open - 6 Mar 2016
avatar corejoomla corejoomla - change - 6 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Mar 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 7 Mar 2016
Rel_Number 0 9186
Relation Type Pull Request for
avatar zero-24
zero-24 - comment - 13 Mar 2016

@pe7er can you have a look here? Looks good from a code review.

avatar pe7er
pe7er - comment - 17 Mar 2016

Thanks for this PR. The code looks good, but I have nothing here at the moment to test it.

btw: due to performance problems with the SQL to count the items, the Category model has been changed a bit a few days ago.

Could you please redo your patch on the most recent code? Thanks!

avatar corejoomla
corejoomla - comment - 17 Mar 2016

Please ignore this pull request.

A new pull request #9462 is created on latest code.

avatar corejoomla corejoomla - change - 17 Mar 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-03-17 21:38:27
Closed_By corejoomla
avatar corejoomla corejoomla - close - 17 Mar 2016

Add a Comment

Login with GitHub to post a comment