? Success

User tests: Successful: Unsuccessful:

avatar b92
b92
4 Mar 2016

Pull Request for Issue # .
W3C compliance error with com_installer. Testing the page /administrator/index.php?option=com_installer with https://validator.w3.org produces "Error : Error: Element style not allowed as child of element div in this context" (From line 431, column 11; to line 431)

Summary of Changes

Use JFactory::getDocument()->addStyleDeclaration() to add the css, instead of adding ccs into the page content with ...

Testing Instructions

Re-test the page with https://validator.w3.org

avatar b92 b92 - open - 4 Mar 2016
avatar b92 b92 - change - 4 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Mar 2016
Labels Added: ?
avatar shubhamnba2009 shubhamnba2009 - test_item - 4 Mar 2016 - Tested unsuccessfully
avatar shubhamnba2009
shubhamnba2009 - comment - 4 Mar 2016

I have tested this item :red_circle: unsuccessfully on ae2c056

After applying the patch and going to the link /administrator/index.php?option=com_installer again following error appears

Parse error: syntax error, unexpected '<' in C:\xampp\htdocs\stagingtest\administrator\components\com_installer\views\install\tmpl\default.php on line 108
Call Stack

Time Memory Function Location

1 0.0013 139600 {main}( ) ..\index.php:0
2 0.1304 2593880 JApplicationCms->execute( ) ..\index.php:51
3 0.1304 2594032 JApplicationAdministrator->doExecute( ) ..\cms.php:257
4 0.1946 3917776 JApplicationAdministrator->dispatch( ) ..\administrator.php:152
5 0.2109 4162304 JComponentHelper::renderComponent( ) ..\administrator.php:98
6 0.2140 4210688 JComponentHelper::executeComponent( ) ..\helper.php:380
7 0.2143 4232064 require_once( 'C:\xampp\htdocs\stagingtest\administrator\components\com_installer\installer.php' ) ..\helper.php:405
8 0.2397 4831416 JControllerLegacy->execute( ) ..\installer.php:19
9 0.2397 4831536 InstallerController->display( ) ..\legacy.php:728
10 0.2652 5303544 InstallerViewInstall->display( ) ..\controller.php:59
11 0.2676 5304848 InstallerViewDefault->display( ) ..\view.html.php:46
12 0.3018 5548464 JViewLegacy->display( ) ..\view.php:62
13 0.3018 5548720 JViewLegacy->loadTemplate( ) ..\legacy.php:209


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9304.

avatar joomla-cms-bot
joomla-cms-bot - comment - 4 Mar 2016

This PR has received new commits.

CC: @shubhamnba2009


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9304.

avatar b92
b92 - comment - 4 Mar 2016

Fixed : added the missing ?>

avatar shubhamnba2009
shubhamnba2009 - comment - 4 Mar 2016

Getting these error on checking the source file of /administrator/index.php?option=com_installer at https://validator.w3.org after applying the patch.

Error: Attribute type not allowed on element div at this point.
From line 423, column 3; to line 429, column 2
apper">↩ ↩ Attributes for element div:
Global attributes
Warning: Section lacks heading. Consider using h2-h6 elements to add identifying headings to all sections.
From line 409, column 2; to line 409, column 23
r-main">↩

↩ <!-
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9304.

avatar b92
b92 - comment - 4 Mar 2016

Please note that fixe concerns only one of the errors on all W3C compliance errors which previsouly exist on the page (you can compare with and without the fixe). The 2 pending error are from the menu, I think, and are existing on most of pages (components) on the backend.

avatar shubhamnba2009 shubhamnba2009 - test_item - 4 Mar 2016 - Tested successfully
avatar shubhamnba2009
shubhamnba2009 - comment - 4 Mar 2016

I have tested this item :white_check_mark: successfully on 55ceb24

Removes Error : Error: Element style not allowed as child of element div in this context" (From line 431, column 11; to line 431) as per https://validator.w3.org validator.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9304.

avatar andrepereiradasilva andrepereiradasilva - test_item - 5 Mar 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 5 Mar 2016

I have tested this item :white_check_mark: successfully on 55ceb24

BTW the other error comes from here https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/sidebars/toggle.php


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9304.

avatar wilsonge wilsonge - change - 5 Mar 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-03-05 19:51:11
Closed_By wilsonge
avatar wilsonge wilsonge - close - 5 Mar 2016
avatar wilsonge wilsonge - reference | c0798e1 - 5 Mar 16
avatar wilsonge wilsonge - merge - 5 Mar 2016
avatar wilsonge wilsonge - close - 5 Mar 2016
avatar wilsonge wilsonge - change - 5 Mar 2016
Milestone Added:
avatar wilsonge
wilsonge - comment - 5 Mar 2016

Merged - thanks!

Add a Comment

Login with GitHub to post a comment