Feeling Lucky
?
?
[#9300] - Remove unneeded translations from rel attribute options.
- Closed
- 4 Mar 2016
- Medium
- Build: staging
- # 9300
- Diff
- Bakual:RemoveTranslatedOptions
- Pending Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for discussion in PR #9282 .
Summary of Changes
Removes translation strings for the options in the new rel attribute parameter. Those aren't needed because we don't need to have those translated.
Testing Instructions
Make sure you can still see and can select each option.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
infograf768
- comment
- 4 Mar 2016
I have tested this item 
successfully on 849fe43
ok here. should go in now. @wilsonge
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9300.
| Status | Pending | ⇒ | Ready to Commit |
infograf768
- comment
- 4 Mar 2016
can be merged on review
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9300.
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-04 17:15:44 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
brianteeman
- | Labels |
Removed:
?
|
||
Original testing instructions apply here as well:
This PR add the ability to set "rel" attribute of a link when you setup a menu item type of external url.
SEO purpose.
Testing Instructions
Before patch
Create a menu item type of "External url", go to tab "Link type", there is no way to setup an rel attribute.
After patch
this should seem like this:
Try switching different rel value, for "None" there is no rel attribute: