? Success

User tests: Successful: Unsuccessful:

avatar GABBAR1947
GABBAR1947
2 Mar 2016

Pull Request for Issue #8859

Testing instructions remain the same as referenced in the issue:
$session = JFactory::getSession();
$session->set('test', 1);
echo $session->set('test', 2);

avatar GABBAR1947 GABBAR1947 - open - 2 Mar 2016
avatar GABBAR1947 GABBAR1947 - change - 2 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2016
Labels Added: ?
avatar richard67
richard67 - comment - 2 Mar 2016

@GABBAR1947 Seems you have indented with 8 spaces and the 1 tab instead of 2 tabs? Or was it edited on GitHub, and GitHub did that?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9285.

avatar richard67 richard67 - test_item - 2 Mar 2016 - Tested successfully
avatar richard67
richard67 - comment - 2 Mar 2016

I have tested this item :white_check_mark: successfully on 21e9fec

Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9285.

avatar GABBAR1947
GABBAR1947 - comment - 2 Mar 2016

@richard67 This is the first time I'm facing such kind of issues on github. It's absolutely fine on my system, must be a github issue, as I indented on github itself in the second commit.

avatar joomla-cms-bot
joomla-cms-bot - comment - 2 Mar 2016

This PR has received new commits.

CC: @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9285.

avatar richard67 richard67 - test_item - 2 Mar 2016 - Tested successfully
avatar richard67
richard67 - comment - 2 Mar 2016

I have tested this item :white_check_mark: successfully on 21e9fec


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9285.

avatar joomla-cms-bot
joomla-cms-bot - comment - 2 Mar 2016

This PR has received new commits.

CC: @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9285.

avatar richard67 richard67 - test_item - 2 Mar 2016 - Tested successfully
avatar richard67
richard67 - comment - 2 Mar 2016

I have tested this item :white_check_mark: successfully on 21e9fec


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9285.

avatar wilsonge wilsonge - change - 2 Mar 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 2 Mar 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2016
Labels Removed: ?
avatar richard67
richard67 - comment - 2 Mar 2016

It seems GitHub (or the bot?) is really confused. Whatever I test after a new commit, it still refers to this old commit 21e9fec, which always drops to the end.

avatar anibalsanchez anibalsanchez - test_item - 2 Mar 2016 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 2 Mar 2016

I have tested this item :white_check_mark: successfully on 21e9fec

Test OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9285.

avatar wilsonge
wilsonge - comment - 2 Mar 2016

Merged

avatar wilsonge wilsonge - change - 2 Mar 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-03-02 22:04:33
Closed_By wilsonge
avatar wilsonge wilsonge - close - 2 Mar 2016
avatar wilsonge wilsonge - close - 2 Mar 2016
avatar wilsonge wilsonge - change - 2 Mar 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment