? Success

User tests: Successful: Unsuccessful:

avatar Radek-Suski
Radek-Suski
2 Mar 2016

Pull Request for Issue #9252

Summary of Changes

Removing root path from the entire output

Testing Instructions

Check if the report contains the path to Joomla! installation

avatar Radek-Suski Radek-Suski - open - 2 Mar 2016
avatar Radek-Suski Radek-Suski - change - 2 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 2 Mar 2016
The description was changed
Labels Added: ?
avatar brianteeman
brianteeman - comment - 2 Mar 2016

@Radek-Suski can you update this as per my comments so it is clear something has been removed from the output

Ignore the Travis failures they are unrelated

avatar Radek-Suski
Radek-Suski - comment - 2 Mar 2016

Done

avatar brianteeman
brianteeman - comment - 2 Mar 2016

Works fine for plain text

Maybe my suggested code was wrong for json as the json still shows the full path
eg

{"writable":false,"message":""},"cache":{"writable":true,"message":"COM_ADMIN_CACHE_DIRECTORY"},"administrator\/cache":{"writable":true,"message":"COM_ADMIN_CACHE_DIRECTORY"},"\/Applications\/MAMP\/htdocs\/joomla-cms-staging\/logs":{"writable":true,"message":"COM_ADMIN_LOG_DIRECTORY"},"\/Applications\/MAMP\/htdocs\/joomla-cms-staging\/tmp":{"writable":true,"message":"COM_ADMIN_TEMP_DIRECTORY"}},"phpInfo":

avatar Radek-Suski
Radek-Suski - comment - 2 Mar 2016

No, I missed a point. Give me few hours. I need to go out for a moment

avatar wilsonge
wilsonge - comment - 2 Mar 2016

Bump Radek :)

avatar Radek-Suski
Radek-Suski - comment - 2 Mar 2016

@wilsonge I fixed it already

avatar andrepereiradasilva
andrepereiradasilva - comment - 2 Mar 2016

@Radek-Suski one full path remains in the json: php open_basedir (if configured on the server), in txt is ok xxxxxxxx but in json is there

And there is also the /etc paths (openssl default config path, opcache blacklist path, for instance).
Don't know if they are a part of this PR though.

avatar brianteeman
brianteeman - comment - 2 Mar 2016

@Radek-Suski Removing it completely (web and download) is not a good solution as it is useful for people to know this


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar brianteeman brianteeman - test_item - 2 Mar 2016 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 2 Mar 2016

I have tested this item :red_circle: unsuccessfully on 1085f72


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar N6REJ
N6REJ - comment - 3 Mar 2016

What impact will this have on extensions that are looking for a file and
need the full path? Just continue as you normally do?
Bear

On 3/2/2016 17:53, Brian Teeman wrote:

@Radek-Suski https://github.com/Radek-Suski Removing it completely
(web and download) is not a good solution as it is useful for people
to know this


_This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at
issues.joomla.org/joomla-cms/9280
https://issues.joomla.org/tracker/joomla-cms/9280.


Reply to this email directly or view it on GitHub
#9280 (comment).

avatar brianteeman
brianteeman - comment - 3 Mar 2016

None at all
On 3 Mar 2016 1:02 am, "Bear" notifications@github.com wrote:

What impact will this have on extensions that are looking for a file and
need the full path? Just continue as you normally do?
Bear

On 3/2/2016 17:53, Brian Teeman wrote:

@Radek-Suski https://github.com/Radek-Suski Removing it completely
(web and download) is not a good solution as it is useful for people
to know this


_This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at
issues.joomla.org/joomla-cms/9280
https://issues.joomla.org/tracker/joomla-cms/9280.


Reply to this email directly or view it on GitHub
#9280 (comment).


Reply to this email directly or view it on GitHub
#9280 (comment).

avatar Radek-Suski
Radek-Suski - comment - 3 Mar 2016

@brianteeman we are removing it from all other paths so it would it doesn't make sense to make an exception for two paths only.
open_basedir would be hard to remove because it is not part of the Joomla! configuration.
I tested the solution and it worked for me. What doesn't work for you @brianteeman?

avatar brianteeman
brianteeman - comment - 3 Mar 2016

@radek-suski We are ONLY removing the full path form the text and the json NOT the web
Example is Session Save Path which is displayed in full in the web interface but is obfuscated to session.save_path: xxxxxx in the json and text download

This last update from you removes the full path for logs and tmp folder in the folder permissions tab from the text, json AND web views it should not be removed from the web view.

Hope that makes sense


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar brianteeman
brianteeman - comment - 3 Mar 2016

@andrepereiradasilva
I tested open_basedir and it is crrectly being removed from the text and json if it is set and still present in the web interface
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/models/sysinfo.php#L113

Not sure what @radek_suski meant about it not being something we can remove - he must need more coffee - as he wrote the code already


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar Radek-Suski
Radek-Suski - comment - 3 Mar 2016

Ok, now I am a bit confused. What is a "web view"?

avatar brianteeman
brianteeman - comment - 3 Mar 2016

The bit you can see in your web browser
On 3 Mar 2016 9:33 am, "Radek Suski" notifications@github.com wrote:

Ok, now I am a bit confused. What is a "web view"?


Reply to this email directly or view it on GitHub
#9280 (comment).

avatar joomla-cms-bot
joomla-cms-bot - comment - 3 Mar 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar joomla-cms-bot
joomla-cms-bot - comment - 3 Mar 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar brianteeman
brianteeman - comment - 3 Mar 2016

Lets try testing it as well ;)

The txt and the json have

Warning: strstr() expects parameter 1 to be string, array given in /Applications/MAMP/htdocs/joomla-cms-staging/administrator/components/com_admin/models/sysinfo.php on line 186


The web now just says

log (Log folder) Writable
tmp (Temp folder) Writable

The web should be as it was before

/Applications/MAMP/htdocs/joomla-cms-staging/logs (Log folder) Writable
/Applications/MAMP/htdocs/joomla-cms-staging/tmp (Temp folder) Writable


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar joomla-cms-bot
joomla-cms-bot - comment - 3 Mar 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar andrepereiradasilva
andrepereiradasilva - comment - 3 Mar 2016

Got

Warning: Missing argument 1 for AdminModelSysInfo::getDirectory(), called in /path/to/joomla-staging/libraries/legacy/view/legacy.php on line 401 and defined in /path/to/joomla-staging/administrator/components/com_admin/models/sysinfo.php on line 501
Notice: Undefined variable: public in /path/to/joomla-staging/administrator/components/com_admin/models/sysinfo.php on line 611
avatar joomla-cms-bot
joomla-cms-bot - comment - 3 Mar 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar andrepereiradasilva
andrepereiradasilva - comment - 3 Mar 2016

For me the only think missing is the open_basedir in the json.
I have two open_basedir in the json, one is hidden the other not.
In the txt both are hidden.

avatar Radek-Suski
Radek-Suski - comment - 3 Mar 2016

In which section is open_basedir?

avatar richard67
richard67 - comment - 3 Mar 2016

"PHP Information", sub section "Core"

avatar andrepereiradasilva
andrepereiradasilva - comment - 3 Mar 2016

In "PHP Settings" the path is hidden (text and json).
In "PHP Information" the path is hidden (text) and the path is visible (json).

avatar richard67
richard67 - comment - 3 Mar 2016

Can confirm @andrepereiradasilva ' findings. Except of open_basedir in json, all is fine.

avatar joomla-cms-bot
joomla-cms-bot - comment - 3 Mar 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar joomla-cms-bot
joomla-cms-bot - comment - 3 Mar 2016

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar richard67
richard67 - comment - 3 Mar 2016

No changes, in open_basedir in PHP information full path still visible.

avatar 1apweb 1apweb - test_item - 3 Mar 2016 - Tested unsuccessfully
avatar 1apweb
1apweb - comment - 3 Mar 2016

I have tested this item :red_circle: unsuccessfully on fe048b1

No change. localhost PHP 5.5.12


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar Radek-Suski
Radek-Suski - comment - 3 Mar 2016

Are you sure. It works for me. It will of corse works only if the JPATH_ROOT and open_basedir are almost the same
screen shot 2016-03-03 at 13 58 58

avatar richard67
richard67 - comment - 3 Mar 2016

@Radek-Suski Well as @andrepereiradasilva wrote it was ok in "PHP Settings", but not in "PHP Information" section.

avatar 1apweb 1apweb - test_item - 3 Mar 2016 - Tested successfully
avatar 1apweb
1apweb - comment - 3 Mar 2016

I have tested this item :white_check_mark: successfully on fe048b1

Sorry it's fixed now


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar anibalsanchez anibalsanchez - test_item - 3 Mar 2016 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 3 Mar 2016

I have tested this item :white_check_mark: successfully on fe048b1

Test OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar andrepereiradasilva andrepereiradasilva - test_item - 3 Mar 2016 - Tested unsuccessfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 3 Mar 2016

I have tested this item :red_circle: unsuccessfully on fe048b1

still the same issue with open_basedir

In "PHP Settings" the path is hidden (text and json).
In "PHP Information" the path is hidden (text) and the path is visible (json).


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar richard67 richard67 - test_item - 3 Mar 2016 - Tested unsuccessfully
avatar richard67
richard67 - comment - 3 Mar 2016

I have tested this item :red_circle: unsuccessfully on fe048b1

Same as @andrepereiradasilva


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar Radek-Suski
Radek-Suski - comment - 3 Mar 2016

Ah, I see. Give me a second

avatar richard67
richard67 - comment - 3 Mar 2016

Even worse now as before, as far as I could see log and temp dirs are also back with full path in json.

avatar joomla-cms-bot
joomla-cms-bot - comment - 3 Mar 2016

This PR has received new commits.

CC: @1apweb, @andrepereiradasilva, @anibalsanchez, @brianteeman, @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar andrepereiradasilva andrepereiradasilva - test_item - 3 Mar 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 3 Mar 2016

I have tested this item :white_check_mark: successfully on 4d4e933

for me is ok
i would advice removing /etc paths too, but in another PR


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar richard67 richard67 - test_item - 3 Mar 2016 - Tested successfully
avatar richard67
richard67 - comment - 3 Mar 2016

I have tested this item :white_check_mark: successfully on 4d4e933

Tested with success, now both text and json format export files do not contain abolute paths anymore, also not for open_basedir, but in the backend sytem information views (html views) they still are shown as it should be.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar joomla-cms-bot
joomla-cms-bot - comment - 3 Mar 2016

This PR has received new commits.

CC: @1apweb, @andrepereiradasilva, @anibalsanchez, @brianteeman, @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar anibalsanchez anibalsanchez - test_item - 3 Mar 2016 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 3 Mar 2016

I have tested this item :white_check_mark: successfully on 60c327c

Test Ok. No paths.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar richard67
richard67 - comment - 3 Mar 2016

@Radek-Suski Shall we wait for further CS fixes for Travis? Or shall we test now? Let us know pls.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar Radek-Suski
Radek-Suski - comment - 3 Mar 2016

Feel free to test. I have no time at the moment to pleasure Travis ;)

avatar richard67
richard67 - comment - 3 Mar 2016

OK. Was not your CS mistakes anyway.

avatar wilsonge
wilsonge - comment - 3 Mar 2016

It's fine - I can fix travis when i merge :)

avatar Radek-Suski
Radek-Suski - comment - 3 Mar 2016

Thanks @wilsonge. You've a beer in Barcelona :dancer:

avatar andrepereiradasilva
andrepereiradasilva - comment - 3 Mar 2016

it's already tested successfully several times, so can be merged IMHO

avatar wilsonge wilsonge - change - 3 Mar 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 3 Mar 2016
Labels Removed: ?
avatar wilsonge
wilsonge - comment - 3 Mar 2016

RTC

avatar wilsonge
wilsonge - comment - 3 Mar 2016

Will merge when I get home tonight.

avatar wilsonge wilsonge - change - 3 Mar 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 3 Mar 2016
Labels Removed: ?
avatar richard67 richard67 - test_item - 3 Mar 2016 - Tested successfully
avatar richard67
richard67 - comment - 3 Mar 2016

I have tested this item :white_check_mark: successfully on 60c327c


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar richard67
richard67 - comment - 3 Mar 2016

@wilsonge It seems joomla-cms-bot does not like you :tongue: Maybe it's better with 2 good tests? Just tested with success.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar 1apweb 1apweb - test_item - 3 Mar 2016 - Tested successfully
avatar 1apweb
1apweb - comment - 3 Mar 2016

I have tested this item :white_check_mark: successfully on 60c327c


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar wilsonge wilsonge - change - 3 Mar 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 3 Mar 2016
Labels Removed: ?
avatar brianteeman brianteeman - change - 3 Mar 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 3 Mar 2016

RTC (again)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.

avatar joomla-cms-bot joomla-cms-bot - change - 3 Mar 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 3 Mar 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-03-03 20:11:29
Closed_By wilsonge
avatar wilsonge wilsonge - close - 3 Mar 2016
avatar joomla-cms-bot joomla-cms-bot - close - 3 Mar 2016
avatar wilsonge wilsonge - close - 3 Mar 2016
avatar wilsonge wilsonge - close - 3 Mar 2016
avatar joomla-cms-bot joomla-cms-bot - change - 3 Mar 2016
Labels Removed: ?
avatar wilsonge wilsonge - change - 6 Mar 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment