User tests: Successful: Unsuccessful:
Pull Request for Issue #9252
Removing root path from the entire output
Check if the report contains the path to Joomla! installation
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Labels |
Added:
?
|
Done
Works fine for plain text
Maybe my suggested code was wrong for json as the json still shows the full path
eg
{"writable":false,"message":""},"cache":{"writable":true,"message":"COM_ADMIN_CACHE_DIRECTORY"},"administrator\/cache":{"writable":true,"message":"COM_ADMIN_CACHE_DIRECTORY"},"\/Applications\/MAMP\/htdocs\/joomla-cms-staging\/logs":{"writable":true,"message":"COM_ADMIN_LOG_DIRECTORY"},"\/Applications\/MAMP\/htdocs\/joomla-cms-staging\/tmp":{"writable":true,"message":"COM_ADMIN_TEMP_DIRECTORY"}},"phpInfo":
No, I missed a point. Give me few hours. I need to go out for a moment
Bump Radek :)
@Radek-Suski one full path remains in the json: php open_basedir (if configured on the server), in txt is ok xxxxxxxx
but in json is there
And there is also the /etc
paths (openssl default config path, opcache blacklist path, for instance).
Don't know if they are a part of this PR though.
@Radek-Suski Removing it completely (web and download) is not a good solution as it is useful for people to know this
I have tested this item unsuccessfully on 1085f72
What impact will this have on extensions that are looking for a file and
need the full path? Just continue as you normally do?
Bear
On 3/2/2016 17:53, Brian Teeman wrote:
@Radek-Suski https://github.com/Radek-Suski Removing it completely
(web and download) is not a good solution as it is useful for people
to know this
_This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at
issues.joomla.org/joomla-cms/9280
https://issues.joomla.org/tracker/joomla-cms/9280.—
Reply to this email directly or view it on GitHub
#9280 (comment).
None at all
On 3 Mar 2016 1:02 am, "Bear" notifications@github.com wrote:
What impact will this have on extensions that are looking for a file and
need the full path? Just continue as you normally do?
BearOn 3/2/2016 17:53, Brian Teeman wrote:
@Radek-Suski https://github.com/Radek-Suski Removing it completely
(web and download) is not a good solution as it is useful for people
to know this
_This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at
issues.joomla.org/joomla-cms/9280
https://issues.joomla.org/tracker/joomla-cms/9280.—
Reply to this email directly or view it on GitHub
#9280 (comment).—
Reply to this email directly or view it on GitHub
#9280 (comment).
@brianteeman we are removing it from all other paths so it would it doesn't make sense to make an exception for two paths only.
open_basedir would be hard to remove because it is not part of the Joomla! configuration.
I tested the solution and it worked for me. What doesn't work for you @brianteeman?
@radek-suski We are ONLY removing the full path form the text and the json NOT the web
Example is Session Save Path which is displayed in full in the web interface but is obfuscated to session.save_path: xxxxxx in the json and text download
This last update from you removes the full path for logs and tmp folder in the folder permissions tab from the text, json AND web views it should not be removed from the web view.
Hope that makes sense
@andrepereiradasilva
I tested open_basedir and it is crrectly being removed from the text and json if it is set and still present in the web interface
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_admin/models/sysinfo.php#L113
Not sure what @radek_suski meant about it not being something we can remove - he must need more coffee - as he wrote the code already
Ok, now I am a bit confused. What is a "web view"?
The bit you can see in your web browser
On 3 Mar 2016 9:33 am, "Radek Suski" notifications@github.com wrote:
Ok, now I am a bit confused. What is a "web view"?
—
Reply to this email directly or view it on GitHub
#9280 (comment).
This PR has received new commits.
CC: @brianteeman
This PR has received new commits.
CC: @brianteeman
Lets try testing it as well ;)
The txt and the json have
Warning: strstr() expects parameter 1 to be string, array given in /Applications/MAMP/htdocs/joomla-cms-staging/administrator/components/com_admin/models/sysinfo.php on line 186
The web now just says
log (Log folder) Writable
tmp (Temp folder) Writable
The web should be as it was before
/Applications/MAMP/htdocs/joomla-cms-staging/logs (Log folder) Writable
/Applications/MAMP/htdocs/joomla-cms-staging/tmp (Temp folder) Writable
This PR has received new commits.
CC: @brianteeman
Got
Warning: Missing argument 1 for AdminModelSysInfo::getDirectory(), called in /path/to/joomla-staging/libraries/legacy/view/legacy.php on line 401 and defined in /path/to/joomla-staging/administrator/components/com_admin/models/sysinfo.php on line 501
Notice: Undefined variable: public in /path/to/joomla-staging/administrator/components/com_admin/models/sysinfo.php on line 611
This PR has received new commits.
CC: @brianteeman
For me the only think missing is the open_basedir
in the json.
I have two open_basedir
in the json, one is hidden the other not.
In the txt both are hidden.
In which section is open_basedir?
"PHP Information", sub section "Core"
In "PHP Settings" the path is hidden (text and json).
In "PHP Information" the path is hidden (text) and the path is visible (json).
Can confirm @andrepereiradasilva ' findings. Except of open_basedir in json, all is fine.
This PR has received new commits.
CC: @brianteeman
This PR has received new commits.
CC: @brianteeman
No changes, in open_basedir in PHP information full path still visible.
I have tested this item unsuccessfully on fe048b1
No change. localhost PHP 5.5.12
@Radek-Suski Well as @andrepereiradasilva wrote it was ok in "PHP Settings", but not in "PHP Information" section.
I have tested this item successfully on fe048b1
Sorry it's fixed now
I have tested this item successfully on fe048b1
Test OK
I have tested this item unsuccessfully on fe048b1
still the same issue with open_basedir
In "PHP Settings" the path is hidden (text and json).
In "PHP Information" the path is hidden (text) and the path is visible (json).
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9280.
I have tested this item unsuccessfully on fe048b1
Same as @andrepereiradasilva
Ah, I see. Give me a second
Even worse now as before, as far as I could see log and temp dirs are also back with full path in json.
This PR has received new commits.
CC: @1apweb, @andrepereiradasilva, @anibalsanchez, @brianteeman, @richard67
I have tested this item successfully on 4d4e933
for me is ok
i would advice removing /etc paths too, but in another PR
I have tested this item successfully on 4d4e933
Tested with success, now both text and json format export files do not contain abolute paths anymore, also not for open_basedir, but in the backend sytem information views (html views) they still are shown as it should be.
This PR has received new commits.
CC: @1apweb, @andrepereiradasilva, @anibalsanchez, @brianteeman, @richard67
I have tested this item successfully on 60c327c
Test Ok. No paths.
@Radek-Suski Shall we wait for further CS fixes for Travis? Or shall we test now? Let us know pls.
Feel free to test. I have no time at the moment to pleasure Travis ;)
OK. Was not your CS mistakes anyway.
It's fine - I can fix travis when i merge :)
it's already tested successfully several times, so can be merged IMHO
Labels |
Added:
?
|
Labels |
Removed:
?
|
RTC
Will merge when I get home tonight.
Labels |
Added:
?
|
Labels |
Removed:
?
|
I have tested this item successfully on 60c327c
@wilsonge It seems joomla-cms-bot does not like you Maybe it's better with 2 good tests? Just tested with success.
I have tested this item successfully on 60c327c
Labels |
Added:
?
|
Labels |
Removed:
?
|
Status | Pending | ⇒ | Ready to Commit |
Labels |
RTC (again)
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-03-03 20:11:29 |
Closed_By | ⇒ | wilsonge |
Labels |
Removed:
?
|
Labels |
Removed:
?
|
@Radek-Suski can you update this as per my comments so it is clear something has been removed from the output
Ignore the Travis failures they are unrelated