[#9277] - $result-variable-undefined-given-default-value
- Closed
- 14 Aug 2016
- Medium
- Build: staging
- # 9277
- Diff
- flash1452:result-undefined
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #9253 .
Summary of Changes
$result redefined with a default value.
Testing Instructions
Enable all errors reporting in php.
Add "exit()" to the end of the onContentAfterSave() method (this is for watching the error)
In the front-end, add a menu item "propose an article".
In the front-end do log as an user which can add article.
When the article is submitted, the following error is displayed:
Notice: Undefined variable: result in /home/plambotte/Public/projets/web/joomla3dev/component-factory/plugins/content/joomla/joomla.php on line 93
After the changes the error are no longer seen.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
onContentAfterSave() is a method in plugins/content/joomla/joomla.php file.
| Rel_Number | 0 | ⇒ | 9253 |
| Relation Type | ⇒ | Pull Request for |
@brianteeman Please test the PR.
Hi,
In testing instruction, mentioned that "In the front-end, add a menu item "propose an article"."
"propose an article" means I have to select "Create Article" of "Article" in menu item, correct?
If yes, then I have created a menu item and submitted an article, but without applying this patch, I got blank page, no notice or error.
I have configure Error Reporting to "Maximum".
Here is my system information:
Joomla! Version: Joomla! 3.4.8 Stable [ Ember ] 24-December-2015 19:30 GMT
Joomla! Platform Version: Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
PHP Version: 5.4.45-3+deb.sury.org~precise+1
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9277.
| Category | ⇒ | Plugins |
I have tested this item
Was able to reproduce the error of the undefinded variable.
Applied patch and error did not re-appear.
Tested for @icampus
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9277.
I have tested this item
I followed your test instructions and was able to reproduce the error. However "exit()" shows me a blank page so I've added a "var_dump()" before the exit. Now I can see this error.
After installing the patch everything is fine. I have also checked the php logs from my local server. ;)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9277.
| Status | Pending | ⇒ | Ready to Commit |
| Category | Plugins | ⇒ | Plugins Front End |
| Labels |
Added:
?
|
||
Not sure because PHPCS should complain, do we need an empty line before foreach?
Yes. if/for/foreach/do/while should all have a blank line before them.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-08-14 16:11:00 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
From where can i enable all errors in PHP and where can i find the method onContentAfterSave().
Thanks in advance for helping.