Please provide testing instructions
On 1 Mar 2016 6:56 pm, "Shubham Rathore" notifications@github.com wrote:

Pull Request for Issue #9169

#9169 .

You can view, comment on, or merge this pull request online at:

#9271
Commit Summary

• issue #9169 solved

File Changes

• M libraries/cms/html/html.php https://github.com/joomla/joomla-cms/pull/9271/files#diff-0 (3)

Patch Links:

• https://github.com/joomla/joomla-cms/pull/9271.patch
• https://github.com/joomla/joomla-cms/pull/9271.diff

—
Reply to this email directly or view it on GitHub
#9271.

Cool, later I will be a famous Joomla tester and may be one of the developer....

@GABBAR1947 Can you address the Code style issues that failed in your PR?

FILE: /libraries/cms/html/html.php
--------------------------------------------------------------------------------
FOUND 5 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 982 | ERROR | Tabs must be used to indent lines; spaces are not allowed
 982 | ERROR | No space found after comma in function call
 983 | ERROR | Tabs must be used to indent lines; spaces are not allowed
 983 | ERROR | No space found after comma in function call
 983 | ERROR | No space found after comma in function call

And Testing instructions would definitely be helpful.

Create a form with a calendar field in a database table. Input a date lower than 1.1.1970, save it and reopen it in the same form. If you see the date, all is ok.

The main issue comes from the fact that we use strftime which uses a different formatstrings for the date format than date does. Simply removing the % unfortunately doesn't the trick. It only works for a subset of the possible options.
See http://php.net/manual/en/function.strftime.php and http://php.net/manual/en/function.date.php

Also the input value currently can in theory be any date which is recognised by PHP. Eg also the format used in Germany (31.01.2016), not only the english one (2016-01-31).

So at the moment you can specify a calendar with a text representation of the date i.e. %B %Y which will render like January 2016. That would completely fail apart with this change :(

There's no way this can be merged in it's present form :/

P.S. Tabs instead of spaces is your issue I think with the code style :)

So , the tests finally passed !

There's no way this can be merged in it's present form

I'm going to close this as in the current form it's not going to be merged (not backward compatible).
If you find another way to solve the issue, feel free to do a new PR or request to reopen this one.