Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#9264] - Remove duplicate code and extend JFilters from Framework

? Success

User tests: Successful: Unsuccessful:

avatar photodude
photodude
1 Mar 2016

Pull Request for Issue "JFilter was not extend from Framework Filter: thus duplicate code"

Summary of Changes

Remove duplicate code and extend JFilters from Framework

Testing Instructions

  1. add patch to 3.5B3 or staging https://docs.joomla.org/Testing_Joomla!_patches
  2. navigate to the backend and frontend and be sure nothing is broken
  3. review various forms in the backend and frontend still work
  4. report your result back here

Thanks to @mbabker and @wilsonge for their help and guidance on this correction.

avatar photodude photodude - open - 1 Mar 2016
avatar photodude photodude - change - 1 Mar 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Mar 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 1 Mar 2016
Category ⇒ Libraries
avatar photodude photodude - reference | c99806a - 1 Mar 16
avatar grhcj grhcj - test_item - 1 Mar 2016 - Tested successfully
avatar grhcj
grhcj - comment - 1 Mar 2016

I have tested this item :white_check_mark: successfully on 55256be

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9264.

avatar shubhamnba2009
shubhamnba2009 - comment - 2 Mar 2016

I have tested this item :white_check_mark: successfully on 55256be
I reviewed the front end and back end going through articles and category form.And they work successfully.

avatar wilsonge wilsonge - change - 2 Mar 2016
Milestone Added:
avatar wilsonge
wilsonge - comment - 2 Mar 2016

RTC

avatar photodude
photodude - comment - 2 Mar 2016

Thanks @shubhamnba2009 and @grhcj For Testing so this could reach RTC.

avatar wilsonge
wilsonge - comment - 2 Mar 2016

This will be merged in 3.5.1 - I'm trying to only merge critical fixes for 3.5.0 at this point!

avatar photodude
photodude - comment - 2 Mar 2016

Understood @wilsonge , I think 3.5.1 milestone is an appropriate choice for this; Especially at this point. (onward towards 3.5.0RC)

avatar wilsonge wilsonge - change - 2 Mar 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 2 Mar 2016
Labels Removed: ?
avatar anibalsanchez anibalsanchez - test_item - 5 Mar 2016 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 5 Mar 2016

I have tested this item :white_check_mark: successfully on 55256be

Test OK

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9264.

avatar brianteeman brianteeman - change - 5 Mar 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 5 Mar 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9264.

avatar joomla-cms-bot joomla-cms-bot - change - 5 Mar 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Removed:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Added:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Added:
avatar brianteeman brianteeman - change - 22 Mar 2016
Milestone Removed:
avatar rdeutz
rdeutz - comment - 12 Apr 2016

@photodude could you have a look at the merging conflicts, thanks

avatar joomla-cms-bot
joomla-cms-bot - comment - 13 Apr 2016

This PR has received new commits.

CC: @anibalsanchez, @grhcj

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9264.

avatar joomla-cms-bot
joomla-cms-bot - comment - 13 Apr 2016

This PR has received new commits.

CC: @anibalsanchez, @grhcj

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9264.

avatar photodude
photodude - comment - 13 Apr 2016

@rdeutz The merge conflicts should be fixed now.

avatar rdeutz rdeutz - close - 13 Apr 2016
avatar rdeutz rdeutz - merge - 13 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 13 Apr 2016
avatar rdeutz rdeutz - reference | 59908b8 - 13 Apr 16
avatar rdeutz rdeutz - merge - 13 Apr 2016
avatar rdeutz rdeutz - close - 13 Apr 2016
avatar rdeutz rdeutz - change - 13 Apr 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-04-13 05:49:32
Closed_By ⇒ rdeutz
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2016
Labels Removed: ?
avatar photodude photodude - head_ref_deleted - 13 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment