?

Success

User tests: Successful: Unsuccessful:

avatar richard67
richard67
29 Feb 2016

Pull Request for new issue.

Summary of Changes

Add missing creation of table #__utf8_conversion to joomla.sql and correct the utf8(mb4) conversion
detection by the database schema manager by handling newly installed Joomla!.

Shame I have forgotten that when making my corrections for utf8(mb4) conversion.

Testing Instructions

  1. Installa fresh Joomla! 3.5.0 Beta 3
  2. Login to the administrator area (backend)
  3. Go to "Extensions -> Manage -> Database"
  4. Expected result: All should be OK and up to date. Actual result: 2 Database Problems Found. 1.Table "#__utf8_conversion" does not exist. (From file 3.5.0-2016-02-26.sql.), and 2. "The Joomla! Core database tables have not been converted yet to UTF-8 Multibyte (utf8mb4)". Click on "Fix" button solves this.
  5. Repeat steps 1 to 3 with staging + patch of this PR applied. Result: All OK, no problems reported.

A zip with staging + this patch can be found here: https://github.com/richard67/joomla-cms/archive/correct-joomla-sql-1.zip

Additional test

Beside this problem, this PR also fixes the creation of the table mentioned above in the database schema manager and in the update sql so it is created with utf8mb4 or utf8 collation, depending on the actual system.

This can be tested by updaing a clean 3.4.8 to a 3.5.0. Beta 3 patched by the changes from this PR here and see if it works the same as with (unpatched) 3.5.0 Beta 3. You can find a patched update package for this test at http://test5.richard-fath.de/Joomla_3.5.0-beta3-Beta-Update_Package_test1.zip.

avatar richard67 richard67 - open - 29 Feb 2016
avatar richard67 richard67 - change - 29 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Feb 2016
Labels Added: ?
avatar richard67 richard67 - change - 29 Feb 2016
The description was changed
avatar richard67
richard67 - comment - 29 Feb 2016

@stellainformatica Please test. Thanks in advance.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9260.

avatar richard67
richard67 - comment - 29 Feb 2016

Ah, sorry, waith with testing, is something missing still. Now this solves only the reported error on missing table, not the reported UTF-8 conversion to be done. I will fix that soon with a commit to this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9260.

avatar richard67 richard67 - change - 29 Feb 2016
The description was changed
avatar richard67
richard67 - comment - 29 Feb 2016

@stellainformatica You can test now, am installation container with the patched 3.5.0 Beta 3 you can find here: https://github.com/richard67/joomla-cms/archive/correct-joomla-sql-1.zip


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9260.

avatar richard67 richard67 - change - 29 Feb 2016
The description was changed
Title
Correct table creation of new #__utf8_conversion table
Correct utf8mb4 / utf8 conversion for newly installed Joomla!
avatar richard67 richard67 - change - 29 Feb 2016
Title
Correct table creation of new #__utf8_conversion table
Correct utf8mb4 / utf8 conversion for newly installed Joomla!
avatar anibalsanchez anibalsanchez - test_item - 29 Feb 2016 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 29 Feb 2016

I have tested this item :white_check_mark: successfully on e15eb6d

Tested correct-joomla-sql-1.zip. OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9260.

avatar andrepereiradasilva
andrepereiradasilva - comment - 29 Feb 2016

tested 3.4.8. (clean install) -> to your 3.5.0 beta 3 (install from url) and all tables were converted to utf8mb4_unicode_ci after two "Fix" in Extensions -> Database.

avatar richard67
richard67 - comment - 29 Feb 2016

@andrepereiradasilva Can you also test new installation as described? Is more important to test this.

avatar richard67
richard67 - comment - 29 Feb 2016

Testing Instructions

  1. Installa fresh Joomla! 3.5.0 Beta 3
  2. Login to the administrator area (backend)
  3. Go to "Extensions -> Manage -> Database"
  4. Expected result: All should be OK and up to date. Actual result: 2 Database Problems Found. 1.Table "#__utf8_conversion" does not exist. (From file 3.5.0-2016-02-26.sql.), and 2. "The Joomla! Core database tables have not been converted yet to UTF-8 Multibyte (utf8mb4)". Click on "Fix" button solves this.
  5. Repeat steps 1 to 4 with staging + patch of this PR applied. Result: All OK, no problems reported.

A zip with staging + this patch can be found here: https://github.com/richard67/joomla-cms/archive/correct-joomla-sql-1.zip

avatar richard67 richard67 - change - 29 Feb 2016
The description was changed
avatar richard67 richard67 - change - 29 Feb 2016
The description was changed
avatar wilsonge wilsonge - test_item - 29 Feb 2016 - Tested successfully
avatar wilsonge
wilsonge - comment - 29 Feb 2016

I have tested this item :white_check_mark: successfully on e15eb6d

Created a fresh installation. Before going to the Extension Manager Database tab I got a MySQL error as a message, after patch no such error


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9260.

avatar wilsonge
wilsonge - comment - 29 Feb 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9260.

avatar andrepereiradasilva
andrepereiradasilva - comment - 29 Feb 2016
Clean Joomla staging install - Before patch

image

Your Clean Joomla staging install - after your patch

image

avatar wilsonge wilsonge - change - 29 Feb 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - test_item - 29 Feb 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 29 Feb 2016

I have tested this item :white_check_mark: successfully on e15eb6d


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9260.

avatar joomla-cms-bot joomla-cms-bot - change - 29 Feb 2016
Labels Removed: ?
avatar wilsonge wilsonge - change - 29 Feb 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-02-29 22:03:02
Closed_By wilsonge
avatar wilsonge wilsonge - close - 29 Feb 2016
avatar wilsonge wilsonge - reference | fc7b5f5 - 29 Feb 16
avatar wilsonge wilsonge - merge - 29 Feb 2016
avatar wilsonge wilsonge - close - 29 Feb 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 29 Feb 2016

one less blocker. thanks again @richard67

avatar richard67 richard67 - head_ref_deleted - 29 Feb 2016
avatar stellainformatica
stellainformatica - comment - 1 Mar 2016

I've tested with the a fresh new install

@test: patch tested, working fine

Thanks richard

Add a Comment

Login with GitHub to post a comment