[#9260] - Correct utf8mb4 / utf8 conversion for newly installed Joomla!
- Closed
- 29 Feb 2016
- Medium
- Build: staging
- # 9260
- Diff
- richard67:correct-joomla-sql-1
- Success Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for new issue.
Summary of Changes
Add missing creation of table #__utf8_conversion to joomla.sql and correct the utf8(mb4) conversion
detection by the database schema manager by handling newly installed Joomla!.
Shame I have forgotten that when making my corrections for utf8(mb4) conversion.
Testing Instructions
- Installa fresh Joomla! 3.5.0 Beta 3
- Login to the administrator area (backend)
- Go to "Extensions -> Manage -> Database"
- Expected result: All should be OK and up to date. Actual result: 2 Database Problems Found. 1.Table "#__utf8_conversion" does not exist. (From file 3.5.0-2016-02-26.sql.), and 2. "The Joomla! Core database tables have not been converted yet to UTF-8 Multibyte (utf8mb4)". Click on "Fix" button solves this.
- Repeat steps 1 to 3 with staging + patch of this PR applied. Result: All OK, no problems reported.
A zip with staging + this patch can be found here: https://github.com/richard67/joomla-cms/archive/correct-joomla-sql-1.zip
Additional test
Beside this problem, this PR also fixes the creation of the table mentioned above in the database schema manager and in the update sql so it is created with utf8mb4 or utf8 collation, depending on the actual system.
This can be tested by updaing a clean 3.4.8 to a 3.5.0. Beta 3 patched by the changes from this PR here and see if it works the same as with (unpatched) 3.5.0 Beta 3. You can find a patched update package for this test at http://test5.richard-fath.de/Joomla_3.5.0-beta3-Beta-Update_Package_test1.zip.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
Ah, sorry, waith with testing, is something missing still. Now this solves only the reported error on missing table, not the reported UTF-8 conversion to be done. I will fix that soon with a commit to this PR.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9260.
@stellainformatica You can test now, am installation container with the patched 3.5.0 Beta 3 you can find here: https://github.com/richard67/joomla-cms/archive/correct-joomla-sql-1.zip
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9260.
| Title |
|
||||||
| Title |
|
||||||
I have tested this item 
successfully on e15eb6d
Tested correct-joomla-sql-1.zip. OK
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9260.
tested 3.4.8. (clean install) -> to your 3.5.0 beta 3 (install from url) and all tables were converted to utf8mb4_unicode_ci after two "Fix" in Extensions -> Database.
@andrepereiradasilva Can you also test new installation as described? Is more important to test this.
Testing Instructions
- Installa fresh Joomla! 3.5.0 Beta 3
- Login to the administrator area (backend)
- Go to "Extensions -> Manage -> Database"
- Expected result: All should be OK and up to date. Actual result: 2 Database Problems Found. 1.Table "#__utf8_conversion" does not exist. (From file 3.5.0-2016-02-26.sql.), and 2. "The Joomla! Core database tables have not been converted yet to UTF-8 Multibyte (utf8mb4)". Click on "Fix" button solves this.
- Repeat steps 1 to 4 with staging + patch of this PR applied. Result: All OK, no problems reported.
A zip with staging + this patch can be found here: https://github.com/richard67/joomla-cms/archive/correct-joomla-sql-1.zip
I have tested this item successfully on e15eb6d
Created a fresh installation. Before going to the Extension Manager Database tab I got a MySQL error as a message, after patch no such error
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9260.
Clean Joomla staging install - Before patch
Your Clean Joomla staging install - after your patch
| Labels |
Added:
?
|
||
I have tested this item successfully on e15eb6d
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9260.
| Labels |
Removed:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-29 22:03:02 |
| Closed_By | ⇒ | wilsonge |
one less blocker. thanks again @richard67
@stellainformatica Please test. Thanks in advance.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9260.