? ? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
27 Feb 2016

This PR will make it clear to which menu the menu items belong.

After patch:
screen shot 2016-02-27 at 08 56 00

@andrepereiradasilva #9218 (comment)
@richard67

avatar infograf768 infograf768 - open - 27 Feb 2016
avatar infograf768 infograf768 - change - 27 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Feb 2016
Labels Added: ? ?
avatar infograf768 infograf768 - change - 27 Feb 2016
Category Administration UI/UX
avatar bertmert bertmert - test_item - 27 Feb 2016 - Tested successfully
avatar bertmert
bertmert - comment - 27 Feb 2016

I have tested this item :white_check_mark: successfully on 1c87b4c


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9227.

avatar richard67 richard67 - test_item - 27 Feb 2016 - Tested successfully
avatar richard67
richard67 - comment - 27 Feb 2016

I have tested this item :white_check_mark: successfully on 1c87b4c

Nice, works like a charm here.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9227.

avatar infograf768 infograf768 - change - 27 Feb 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 27 Feb 2016

RTC. Thanks for testing.

If #8411 was ever considered, this would require a slight change as we would have no $menutype when displaying all menu items


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9227.

avatar joomla-cms-bot joomla-cms-bot - change - 27 Feb 2016
Labels Added: ?
avatar brianteeman brianteeman - test_item - 27 Feb 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 27 Feb 2016

I have tested this item :white_check_mark: successfully on 1c87b4c


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9227.

avatar brianteeman
brianteeman - comment - 27 Feb 2016

If #8411 is accepted as well what is displayed in the title bar when you have "all menu itms" selected?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9227.

avatar andrepereiradasilva andrepereiradasilva - test_item - 27 Feb 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 27 Feb 2016

I have tested this item :white_check_mark: successfully on 1c87b4c

works fine.

One commnent. In the other views that have a view selector we use: xxxxxx - Site ou xxxxxx - Administrator, here we use xxxxxx (menu title).
IMHO the other views should be updated to follow this logic, ex:

  • Maintenance: Clear Cache (Site)
  • Maintenance: Clear Cache (Administrator)
  • Modules (Site)
  • Modules (Administrator)
  • Languages: Installed (Site)
  • Languages: Installed (Administrator)

Following the same logic everywhere is more user friendly.
What do you think?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9227.

avatar brianteeman
brianteeman - comment - 27 Feb 2016

I agree


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9227.

avatar infograf768
infograf768 - comment - 27 Feb 2016

If #8411 is accepted as well what is displayed in the title bar when you have "all menu itms" selected?

it would be a new string, something like
Menus : All menu items

with a conditional

avatar wilsonge
wilsonge - comment - 27 Feb 2016

Merging this. JM #8411 will need to be updated after this

avatar wilsonge wilsonge - change - 27 Feb 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-02-27 15:33:37
Closed_By wilsonge
avatar wilsonge wilsonge - reference | 5ae8bc3 - 27 Feb 16
avatar wilsonge wilsonge - merge - 27 Feb 2016
avatar wilsonge wilsonge - close - 27 Feb 2016
avatar wilsonge wilsonge - change - 27 Feb 2016
Milestone Added:
avatar infograf768
infograf768 - comment - 27 Feb 2016

Instead of updating #8411 I created a new PR #9231

Concerning the parenthesis, no objection.

avatar joomla-cms-bot joomla-cms-bot - change - 27 Feb 2016
Labels Removed: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 27 Feb 2016

ok. will do a PR for that

Add a Comment

Login with GitHub to post a comment