User tests: Successful: Unsuccessful:
Pull Request for Issue #9224 .
Fixed missing parameter.
Just add mod_languages
module. Select Use Dropdown and deselect Languages Full Names. Then go to front and look at mod_languages
select field.
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Can be a good idea. Better to have both.
@infograf768 yes #9095 should be improved.
But #9095 is only for 3.6.0
This PR solves a bug that IMHO can be in 3.5.0.
Category | ⇒ | Modules Multilanguage |
FYI, it is not a bug. It was never intended since we implemented the switcher to show uppercase language sef in the dropdown.
I am a bit concerned here by B/C. I explain.
If a user has, by mistake or just as it had no impact until now, set the Language Full Names to "No", then it will change the dropdown display without the user knowledge.
field tooltip: <strong>Languages Full Names</strong><br />If set to 'Yes' and image flags set to 'No', full content language native names are displayed. If set to 'No', upper case abbreviations from the content languages URL Language Code are used. Example: EN for English, FR for French.
reggarding the B/C i understnad your concerns, but woudn't that make resolving bugs in all parameters B/C? Is thta part of the b/c policy?
you forgot the spacer:
MOD_LANGUAGES_SPACERDROP_LABEL="<u>If Use Dropdown is set to 'Yes', <br />the display options below will be ignored</u>"
oh ok :)
you're right then !
I have tested this item unsuccessfully on 9e3dd69
As previous comments.
Patch it self works. No idea why you mark this test as unseccesful. This is more about the fact that when applied module will change the way settings are interpreted (in my opinion it should be like this from the begining, simple logic). If you want to ignore this patch it can be a good idea to use "showon" with full_names field. It will be less confusing. And maybe merge this into previously mentioned patch with flags in dropdown.
Patch it self works. No idea why you mark this test as unseccesful. This is more about the fact that when applied module will change the way settings are interpreted (in my opinion it should be like this from the begining, simple logic).
artur, yes i marked unsuccessfully, because as the current language switcher behaviour this is not a bug, as explained in the posts above.
Your code seems correct and works fine, and i agree with you that should had work like this since the beginning.
But unfortunately it didn't, so infograf as reason when it can have repercussions on users sites.
Thanks for your contribution, but as you can see for previous posts this raises some issues, so for me, as it is now, is a "no go".
If you want to ignore this patch it can be a good idea to use "showon" with full_names field. It will be less confusing. And maybe merge this into previously mentioned patch with flags in dropdown.
I let infograf decide if he want to change the behaviour in his patch.
Rel_Number | 0 | ⇒ | 9224 |
Relation Type | ⇒ | Pull Request for |
Category | Modules Multilanguage | ⇒ | Front End Modules Multilanguage |
Labels |
Added:
?
|
Since we all agree this is a nice to have, I have added the label to re-evaluate for Joomla 4. This way we can have a look at it later when B/C is not an issue.
@infograf768 are you ok when this gets into 4?
I suppose better then never?
OK, will try to make patch. The showon may become a bit complex.
@infograf768 What showon has to do with this?
The Language Full Names field should only be displayed in certain cases in the form. Please look at the xml where we make extensive use of showon.
I don't see anything like that in source branch module declaration. I suppose it is new in version 4. My bad
Please test #20192 (using https://github.com/joomla/joomla-cms/archive/4.0-dev.zip before patch) .
Closing as we have a patch.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-18 06:49:30 |
Closed_By | ⇒ | infograf768 |
I have tested this item successfully on 9e3dd69
Works.
@infograf768, for reference, i think PR #9095 is hidding this option can you check?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9225.