? ? Pending
Pull Request for # 9224

User tests: Successful: Unsuccessful:

avatar artur-stepien
artur-stepien
26 Feb 2016

Pull Request for Issue #9224 .

Summary of Changes

Fixed missing parameter.

Testing Instructions

Just add mod_languages module. Select Use Dropdown and deselect Languages Full Names. Then go to front and look at mod_languages select field.

avatar artur-stepien artur-stepien - open - 26 Feb 2016
avatar artur-stepien artur-stepien - change - 26 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Feb 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - test_item - 26 Feb 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 26 Feb 2016

I have tested this item :white_check_mark: successfully on 9e3dd69

Works.

@infograf768, for reference, i think PR #9095 is hidding this option can you check?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9225.

avatar infograf768
infograf768 - comment - 27 Feb 2016

Imho , as it is very easy to do an override (as nobody for years has ever asked for that type of dropdown), we should rather consider improving #9095.

avatar artur-stepien
artur-stepien - comment - 27 Feb 2016

Can be a good idea. Better to have both.

avatar andrepereiradasilva
andrepereiradasilva - comment - 27 Feb 2016

@infograf768 yes #9095 should be improved.
But #9095 is only for 3.6.0

This PR solves a bug that IMHO can be in 3.5.0.

avatar brianteeman brianteeman - change - 27 Feb 2016
Category Modules Multilanguage
avatar infograf768
infograf768 - comment - 28 Feb 2016

FYI, it is not a bug. It was never intended since we implemented the switcher to show uppercase language sef in the dropdown.

I am a bit concerned here by B/C. I explain.
If a user has, by mistake or just as it had no impact until now, set the Language Full Names to "No", then it will change the dropdown display without the user knowledge.

avatar andrepereiradasilva
andrepereiradasilva - comment - 28 Feb 2016

field tooltip: <strong>Languages Full Names</strong><br />If set to 'Yes' and image flags set to 'No', full content language native names are displayed. If set to 'No', upper case abbreviations from the content languages URL Language Code are used. Example: EN for English, FR for French.

reggarding the B/C i understnad your concerns, but woudn't that make resolving bugs in all parameters B/C? Is thta part of the b/c policy?

avatar infograf768
infograf768 - comment - 28 Feb 2016

you forgot the spacer:
MOD_LANGUAGES_SPACERDROP_LABEL="<u>If Use Dropdown is set to 'Yes', <br />the display options below will be ignored</u>"

avatar andrepereiradasilva
andrepereiradasilva - comment - 28 Feb 2016

oh ok :)
you're right then !

avatar andrepereiradasilva andrepereiradasilva - test_item - 28 Feb 2016 - Tested unsuccessfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 28 Feb 2016

I have tested this item :red_circle: unsuccessfully on 9e3dd69

As previous comments.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9225.

avatar artur-stepien
artur-stepien - comment - 28 Feb 2016

Patch it self works. No idea why you mark this test as unseccesful. This is more about the fact that when applied module will change the way settings are interpreted (in my opinion it should be like this from the begining, simple logic). If you want to ignore this patch it can be a good idea to use "showon" with full_names field. It will be less confusing. And maybe merge this into previously mentioned patch with flags in dropdown.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9225.

avatar andrepereiradasilva
andrepereiradasilva - comment - 28 Feb 2016

Patch it self works. No idea why you mark this test as unseccesful. This is more about the fact that when applied module will change the way settings are interpreted (in my opinion it should be like this from the begining, simple logic).

artur, yes i marked unsuccessfully, because as the current language switcher behaviour this is not a bug, as explained in the posts above.

Your code seems correct and works fine, and i agree with you that should had work like this since the beginning.

But unfortunately it didn't, so infograf as reason when it can have repercussions on users sites.

Thanks for your contribution, but as you can see for previous posts this raises some issues, so for me, as it is now, is a "no go".

If you want to ignore this patch it can be a good idea to use "showon" with full_names field. It will be less confusing. And maybe merge this into previously mentioned patch with flags in dropdown.

I let infograf decide if he want to change the behaviour in his patch.

avatar brianteeman brianteeman - change - 11 Mar 2016
Rel_Number 0 9224
Relation Type Pull Request for
avatar joomla-cms-bot joomla-cms-bot - change - 1 Aug 2016
Category Modules Multilanguage Front End Modules Multilanguage
avatar roland-d roland-d - change - 1 Aug 2016
Labels Added: ?
avatar roland-d
roland-d - comment - 1 Aug 2016

Since we all agree this is a nice to have, I have added the label to re-evaluate for Joomla 4. This way we can have a look at it later when B/C is not an issue.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9225.

avatar laoneo
laoneo - comment - 10 Apr 2018

@infograf768 are you ok when this gets into 4?

avatar artur-stepien
artur-stepien - comment - 10 Apr 2018

I suppose better then never?

avatar infograf768
infograf768 - comment - 11 Apr 2018

@laoneo
not at my desk until the 17th. will re-evaluate when back. can you remind me on glip? thanks

avatar infograf768
infograf768 - comment - 17 Apr 2018

OK, will try to make patch. The showon may become a bit complex.

avatar artur-stepien
artur-stepien - comment - 17 Apr 2018

@infograf768 What showon has to do with this?

avatar infograf768
infograf768 - comment - 17 Apr 2018

The Language Full Names field should only be displayed in certain cases in the form. Please look at the xml where we make extensive use of showon.

avatar artur-stepien
artur-stepien - comment - 17 Apr 2018

I don't see anything like that in source branch module declaration. I suppose it is new in version 4. My bad

avatar infograf768
infograf768 - comment - 18 Apr 2018

Please test #20192 (using https://github.com/joomla/joomla-cms/archive/4.0-dev.zip before patch) .
Closing as we have a patch.

avatar infograf768 infograf768 - change - 18 Apr 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-04-18 06:49:30
Closed_By infograf768
avatar infograf768 infograf768 - close - 18 Apr 2018

Add a Comment

Login with GitHub to post a comment