Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#9222] - Regression: Messages paragraph spacing

? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
26 Feb 2016

Summary of Changes

This PR partly revert the changes made in PR #9181

Unfortunately we had some side effect after that PR: When using messages with several "p" tags the line spacing has also lost. Two of those examples are the Stats notification and the Post install messages as show in the image below.
image

This PR, besides reverting the "p" tag spacing, also changes the message container from a "p" tag to a "div" tag. This will also allow to had block level HTML elements inside the message ("p", "ul", "ol" etc).

After applying the patch you will see all message as before and this "special" messages with the correct spacing between paragraph as one can see in the image below.

image

Testing Instructions

  1. Use latest staging.
  2. Enable stats plugin and reset the unique id, so the message appears.
  3. Go to control panel and check the paragraph spacing.
  4. Apply this PR and clean browser cache (Ctrl+F5)
  5. Repeat step 3. You will see the message is now with the correct spacing between paragraphs.
  6. Check other info, warning, sucess and error messages in the frontend and in the backend.
avatar andrepereiradasilva andrepereiradasilva - open - 26 Feb 2016
avatar andrepereiradasilva andrepereiradasilva - change - 26 Feb 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Feb 2016
Labels Added: ?
avatar brianteeman brianteeman - test_item - 26 Feb 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 26 Feb 2016

I have tested this item :white_check_mark: successfully on 7715371

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9222.

avatar brianteeman
brianteeman - comment - 26 Feb 2016

When testing dont forget that you must be testing on current staging AND that you clear you browser cache after applying the patch

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9222.

avatar richard67 richard67 - test_item - 26 Feb 2016 - Tested successfully
avatar richard67
richard67 - comment - 26 Feb 2016

I have tested this item :white_check_mark: successfully on 7715371

Tested with success.

I had to clear browser cache also before the patch in order to be able to reproduce the error.

So clear browser cache at test start and then again after applying the patch.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9222.

avatar brianteeman brianteeman - change - 26 Feb 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 26 Feb 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9222.

avatar joomla-cms-bot joomla-cms-bot - change - 26 Feb 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 27 Feb 2016
Milestone Added:
avatar wilsonge wilsonge - reference | 025fbe2 - 27 Feb 16
avatar wilsonge wilsonge - merge - 27 Feb 2016
avatar wilsonge wilsonge - close - 27 Feb 2016
avatar wilsonge wilsonge - change - 27 Feb 2016
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-02-27 01:44:21
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 27 Feb 2016
avatar joomla-cms-bot joomla-cms-bot - close - 27 Feb 2016
avatar joomla-cms-bot joomla-cms-bot - change - 27 Feb 2016
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 27 Feb 2016

Add a Comment

Login with GitHub to post a comment