? ? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
26 Feb 2016

This PR modifies the Modules Toolbar Title to specify the client displayed.

After patch:
screen shot 2016-02-26 at 09 50 35
screen shot 2016-02-26 at 09 50 17

avatar infograf768 infograf768 - open - 26 Feb 2016
avatar infograf768 infograf768 - change - 26 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Feb 2016
Labels Added: ? ?
avatar brianteeman brianteeman - test_item - 26 Feb 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 26 Feb 2016

I have tested this item :white_check_mark: successfully on a2241a1


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9218.

avatar bertmert bertmert - test_item - 26 Feb 2016 - Tested successfully
avatar bertmert
bertmert - comment - 26 Feb 2016

I have tested this item :white_check_mark: successfully on a2241a1


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9218.

avatar infograf768 infograf768 - change - 26 Feb 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 26 Feb 2016

RTC. Thanks for testing.

@wilsonge I guess this can go in 3.5.0 as we are not yet in language freeze.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9218.

avatar joomla-cms-bot joomla-cms-bot - change - 26 Feb 2016
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 26 Feb 2016

@infograf768 for consistency can you do a similar PR to com_cache cache view?

Will update the installed language PR (#9102) to do the same thing so this can be consistent in all cases.

A question ask, another view that has a view selector is com_menus items view. Should a similiar change also be applied there?

avatar infograf768
infograf768 - comment - 26 Feb 2016

Will do for com_cache now and look what can be done for menu items.

BTW, for menu items I have an unrelated older PR not enough tested: https://issues.joomla.org/tracker/joomla-cms/8411

avatar joomla-cms-bot
joomla-cms-bot - comment - 26 Feb 2016

This PR has received new commits.

CC: @bertmert, @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9218.

avatar infograf768
infograf768 - comment - 26 Feb 2016

Just deleted an empty line.

avatar andrepereiradasilva andrepereiradasilva - test_item - 26 Feb 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 26 Feb 2016

I have tested this item :white_check_mark: successfully on ab88013


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9218.

avatar wilsonge wilsonge - change - 26 Feb 2016
Milestone Added:
avatar wilsonge wilsonge - change - 26 Feb 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-02-26 11:06:28
Closed_By wilsonge
avatar wilsonge wilsonge - reference | 99aa33b - 26 Feb 16
avatar wilsonge wilsonge - merge - 26 Feb 2016
avatar wilsonge wilsonge - close - 26 Feb 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 26 Feb 2016

@infograf768 BTW somewhat related to this PR, shouldn't, from a usability point, com_templates also have a client selector?

IMHO just a very few people changes or edits the admin template so why confuse users with admin templates when we can have a client selector like the one used in other views (installed languages, cache and modules)?

avatar joomla-cms-bot joomla-cms-bot - change - 26 Feb 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment