[#921] - Fixes bug in countMenuChildren which makes it always return 0
- Closed
- 13 Jun 2014
- Medium
- Build: master
- # 921
- Diff
- Paladin:fixCountMenuChildren
- Error default This pull request is targeted at the master branch. Pull requests should no longer be merged to master. Details
User tests: Successful: Unsuccessful:
The query wasn't getting set before getting the results. Now it is. I'm resending it and closing the other, because it looked like some of my PR's were a little corrupted, and github makes recreating them so easy I figured I might as well touch every one of them again.
And Nick, my experiences interacting with Joomlacode issue tracker and submission process scarred me years ago. It has been several years (I may even still have a project or two on it that I haven't touched) so I'll accept that maybe it's changed for the better since, and sometime when I feel I can afford the time I may go back and try it again. But for right now, I'm here, the cms code is here, and jumping to another system that I neither like nor trust seems a needless waste of time. If that's what you need to have in order to fix a bug, I guess it'll have to wait until then.
Hi Arlen, I just saw your message. Edits of github comments do not result in notifications by email, so my apologies for the other messages. I'm not trying to spam you :P
Sounds good. I'll just create the tracker items for you from now on :)
I'm closing this because the issue was already fixed in: 54df5bf#diff-b6d463656b3040771a9216e7937fb402R534
Thanks!!
Thanks for coding this, Arlen!
While we’re transitioning to a new integrated tracker, could you report the issue on our current main tracker at JoomlaCode and cross-reference each with a link to the other? Here’s the process for reporting on the other tracker:
http://docs.joomla.org/Filing_bugs_and_issues
Alternatively, let me know if you’d like me to create it for you and I can go ahead and do that.
Thanks in advance and thanks again for coding this, Arlen!