? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
24 Feb 2016

Description

This PR adds searchtools to com_categories modal layout categories view.

Also, in normal layout:

  • correct bug: the modal on mobile xs show a column without title.
  • correct bug: ordering the view for Association doesn't add the arrow icon (removed ordering in this column).
  • improves responsive visual (mobile/tablet/desktop)
  • solves other minor graphical issues.
  • minor code style improvements
Before PR (modal)

before-pr

After PR (modal)

after-pr

How to test

Normal view:
1. Install latest staging and apply this patch
2. Go to Content -> Categories
3. Check if search, filters, ordering and pagination are working properly
4. Test on mobile and tablet (ex: reduce browser width)

Modal view:
1. Enable language associations.
2. Create some categories in several languages.
3. Edit one of those categories and go to "Associations" tab and click on "Select" on any language.
4. Check if search, filters, ordering and pagination are working properly in modal.
5. Test on mobile and tablet (ex: reduce browser width)

Should be also tested in other extensions that use categories (ex: User Notes, Contacts, Banners and News Feeds)

avatar andrepereiradasilva andrepereiradasilva - open - 24 Feb 2016
avatar andrepereiradasilva andrepereiradasilva - change - 24 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 24 Feb 2016
Title
Com categories searchtools
[com_categories] add searchtools to modal layout and solves bugs
avatar infograf768 infograf768 - test_item - 25 Feb 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 25 Feb 2016

I have tested this item :white_check_mark: successfully on 4ce7fae


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9208.

avatar brianteeman brianteeman - test_item - 28 Feb 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 28 Feb 2016

I have tested this item :white_check_mark: successfully on 4ce7fae


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9208.

avatar brianteeman brianteeman - change - 28 Feb 2016
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 28 Feb 2016
Category Administration UI/UX
avatar brianteeman
brianteeman - comment - 28 Feb 2016

RTC - thanks once again


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9208.

avatar joomla-cms-bot joomla-cms-bot - change - 28 Feb 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 12 Apr 2016
Milestone Added:
avatar brianteeman brianteeman - change - 12 Apr 2016
Milestone Added:
avatar rdeutz
rdeutz - comment - 13 Apr 2016

@andrepereiradasilva could you have a look at the merge conflicts, thanks.

avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Apr 2016

This PR has received new commits.

CC: @brianteeman, @infograf768


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9208.

avatar joomla-cms-bot joomla-cms-bot - change - 14 Apr 2016
Labels Added: ?
avatar joomla-cms-bot
joomla-cms-bot - comment - 14 Apr 2016

This PR has received new commits.

CC: @brianteeman, @infograf768


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9208.

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Apr 2016

conflicts fixed.
@brianteeman can you remove the Unit tests label again? sorry

avatar brianteeman brianteeman - change - 14 Apr 2016
Labels Removed: ?
avatar rdeutz rdeutz - close - 14 Apr 2016
avatar rdeutz rdeutz - merge - 14 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 14 Apr 2016
avatar rdeutz rdeutz - reference | 7d64a26 - 14 Apr 16
avatar rdeutz rdeutz - merge - 14 Apr 2016
avatar rdeutz rdeutz - change - 14 Apr 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-04-14 21:17:48
Closed_By rdeutz
avatar rdeutz rdeutz - close - 14 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 14 Apr 2016
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 14 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment