[#9206] - [com_newsfeeds] add searchtools to modal layout and solves bugs
- Fixed in Code Base
- 14 Apr 2016
- Medium
- Build: staging
- # 9206
- Diff
- andrepereiradasilva:com_newsfeeds_searchtools
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Description
This PR adds searchtools to com_newsfeeds modal layout newsfeeds view.
The modal hasn't working properly (wasn't forcing the language in language association modal).
Also, in normal layout:
- correct bug: ordering the view for Association doesn't add the arrow icon (removed ordering in this column).
- improves responsive visual (mobile/tablet/desktop)
- solves other minor graphical issues.
- minor code style improvements
Before PR (modal)
After PR (modal)
How to test
Normal view:
1. Install latest staging and apply this patch
2. Go to Components -> News Feeds
3. Check if search, filters, ordering and pagination are working properly
4. Test on mobile and tablet (ex: reduce browser width)
Modal view:
1. Enable language associations.
2. Create some news feeds in several languages.
3. Edit one of those news feeds and go to "Associations" tab and click on "Select" on any language.
4. Check if search, filters, ordering and pagination are working properly in modal.
5. Test on mobile and tablet (ex: reduce browser width)
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
I have tested this item 
successfully on 32c1ca5
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9206.
| Category | ⇒ | Administration UI/UX |
I have tested this item successfully on 32c1ca5
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9206.
| Status | Pending | ⇒ | Ready to Commit |
RTC -thanks for being so thorough in finding all of these issues
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9206.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
@andrepereiradasilva could you have a look at the merge conflicts, thanks.
This PR has received new commits.
CC: @brianteeman, @infograf768
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9206.
This PR has received new commits.
CC: @brianteeman, @infograf768
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9206.
fixed conflicts
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-14 22:05:49 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
To testers, this PR includes the same changes to the field type "Category" as #9195 and #9198
Therefore they have to be tested separately after reverting these.