[#9204] - Improving JTableNested::delete()
- Closed
- 9 Apr 2016
- Medium
- Build: staging
- # 9204
- Diff
- Hackwar:tablenesteddelete
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This change brings a performance improvement to JTableNested::delete(). This eliminates one query per item to be deleted. If you would for example clear your trash with 200 categories, this means 200 queries less with this change. Since we are using JTableNested for the assets table, this would mean that also deleting articles would receive a performance boost.
Testing Instructions
YAUTPR - Yet Another Un-Testable Pull Request
You can test this PR by deleting a category for example and afterwards everything should still work. However, this actually needs a proper code review by a seasoned developer/maintainer.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
I have tested by deleting a category, restoring from Trash, deleting again and empty Trash. All still working as expected
I have tested this item 
successfully on baf3f1e
Tested and works as expected
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9204.
wilsonge
- | Milestone |
Added: |
||
| Category | ⇒ | Libraries |
Flagging Needs Review (as kind of requested)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9204.
| Status | Pending | ⇒ | Needs Review |
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-09 14:01:50 |
| Closed_By | ⇒ | wilsonge |
I have tested this item
successfully on baf3f1e
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9204.