? Error

User tests: Successful: Unsuccessful:

avatar miguelbgouveia
miguelbgouveia
24 Feb 2016

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Creation of an identifier field property in order to define the table field that store the identifier.
I need to create a plugin to a specific module that have identifier field in table other than id.

avatar miguelbgouveia miguelbgouveia - open - 24 Feb 2016
avatar miguelbgouveia miguelbgouveia - change - 24 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Feb 2016
Labels Added: ?
avatar miguelbgouveia
miguelbgouveia - comment - 24 Feb 2016

I was creating an smart search plugin for a specific component.
The problem is that component use a table where the identifier field don't have the 'id' name.
To resolve the problem it will be good if I could specified the field identifier name in cases that the name is other than 'id'.

I just create an pull request with the solution but it don't pass in the CI tool in some php versions.
The pull request is #9202

avatar brianteeman
brianteeman - comment - 24 Feb 2016

Someone else can confirm but looks to me like an issue with the CI tool and not your code @wilsonge @mbabker

avatar mbabker
mbabker - comment - 24 Feb 2016

Resubmit to staging, 3.5-dev is effectively closed since it was merged into
staging (should be deleted once any PRs still targeting it are handled)

On Wednesday, February 24, 2016, Brian Teeman notifications@github.com
wrote:

Someone else can confirm but looks to me like an issue with the CI tool
and not your code @wilsonge https://github.com/wilsonge @mbabker
https://github.com/mbabker


Reply to this email directly or view it on GitHub
#9202 (comment).

avatar miguelbgouveia
miguelbgouveia - comment - 24 Feb 2016

Ok, thanks for the information. Any other actions needed for this pull be accepted?

avatar miguelbgouveia
miguelbgouveia - comment - 24 Feb 2016

Can I submit it to any other branch?

avatar dgt41
dgt41 - comment - 24 Feb 2016

staging will do

avatar brianteeman
brianteeman - comment - 24 Feb 2016

Sorry I missed that you had submitted to the wrong branch

As @mbabker stated please resubmit to the staging branch - it will then need to be tested/reviewed by others before it is considered to be merged.

Closing as you will be creating a new PR on the correct branch

avatar brianteeman brianteeman - change - 24 Feb 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-02-24 17:45:44
Closed_By brianteeman
avatar brianteeman brianteeman - close - 24 Feb 2016
avatar brianteeman brianteeman - close - 24 Feb 2016
avatar mbabker
mbabker - comment - 24 Feb 2016

Submit it against the staging branch, make sure CI passes (if you changed
something affecting unit tested code the tests shouldn't break, and on
staging the PHP 5.6 run also tests code style compliance), then it just
needs testing & review.

On Wednesday, February 24, 2016, Miguel Gouveia notifications@github.com
wrote:

Can I submit it to any other branch?


Reply to this email directly or view it on GitHub
#9202 (comment).

Add a Comment

Login with GitHub to post a comment