[#9198] - [com_contact] add searchtools to modal layout and solves bugs
- Fixed in Code Base
- 14 Apr 2016
- Medium
- Build: staging
- # 9198
- Diff
- andrepereiradasilva:com_contact_searchtools
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Description
This PR adds searchtools to com_contact modal layout contacts view.
Also, in normal layout:
- correct bug: by default the filter was open with no filters selected.
- correct bug: when selecting the category filter or the tag filter the searchtools hides.
- improves responsive visual (mobile/tablet/desktop)
- solves other minor graphical issues.
- minor code style improvements
Before PR
After PR
Before PR (modal)
After PR (modal)
How to test
Normal view:
1. Install latest staging and apply this patch
2. Go to Components -> Contacts
3. Check if search, filters, ordering and pagination are working properly
4. Test on mobile and tablet (ex: reduce browser width)
Modal view:
1. Enable language associations.
2. Create some contacts in several languages.
3. Edit one of those contacts and go to "Associations" tab and click on "Select" on any language.
4. Check if search, filters, ordering and pagination are working properly in modal.
5. Test on mobile and tablet (ex: reduce browser width)
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
| Title |
|
||||||
I have tested this item 
successfully on 6297df5
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9198.
| Status | Pending | ⇒ | Ready to Commit |
RTC - thanks again
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9198.
| Labels |
Added:
?
|
||
| Category | ⇒ | Administration UI/UX |
| Labels | |||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
@andrepereiradasilva could you have a look at the merge conflicts, thanks.
This PR has received new commits.
CC: @brianteeman, @infograf768
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9198.
This PR has received new commits.
CC: @brianteeman, @infograf768
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9198.
This PR has received new commits.
CC: @brianteeman, @infograf768
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9198.
This PR has received new commits.
CC: @brianteeman, @infograf768
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9198.
This PR has received new commits.
CC: @brianteeman, @infograf768
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9198.
conflicts fixed
This PR has received new commits.
CC: @brianteeman, @infograf768
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9198.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-14 22:07:19 |
| Closed_By | ⇒ | rdeutz |
| Labels |
Removed:
?
|
||
| Milestone |
Removed: |
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Milestone |
Removed: |
||
I have tested this item
successfully on 6297df5
Works fine.
To testers, this PR includes the same changes to the field type "Category" as #9195.
Therefore they have to be tested separately after reverting one of them.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9198.