? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
22 Feb 2016

#9101 has changed the way to look for the client.
It now uses getState('client_id') instead of getState('filter.client_id')

This has an impact on Hathor where the location column is wrong in the installed languages column view.

Before patch
hathor_before

After patch
hathor_after

@andrepereiradasilva @brianteeman @richard67

avatar infograf768 infograf768 - open - 22 Feb 2016
avatar infograf768 infograf768 - change - 22 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Feb 2016
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Feb 2016

thanks.
You have to change it in the form action too. "client=" to "client_id="

avatar infograf768
infograf768 - comment - 22 Feb 2016

@andrepereiradasilva

You have to change it in the form action too. "client=" to "client_id="

Not sure. the url looks correct with client= ' .$clientId);

avatar infograf768
infograf768 - comment - 22 Feb 2016

@andrepereiradasilva
Tested your proposal. I see no effect on the results.
In fact taking off completely the client in the url also works fine here.
<form action="<?php echo JRoute::_('index.php?option=com_languages&view=installed'); ?>" method="post" id="adminForm" name="adminForm">

??

avatar infograf768
infograf768 - comment - 22 Feb 2016

Anyway, as client_id is now used for the tabs, I changed it too here.

avatar brianteeman brianteeman - change - 22 Feb 2016
Category Multilanguage Templates (admin)
avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Feb 2016

yes, thinking better, you don't even need the Location column now.
So all that can be removed.

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Feb 2016

BTW what is hathor still used for? Does anyone really uses it?

avatar richard67
richard67 - comment - 22 Feb 2016

@andrepereiradasilva As far as I remember from past discussions, Hathor is a crab with its half a million overrides but still the only admin template having certain accessibility features like high contrast styles, which Isis does not have yet, and so because of accessibility requirements for the backend Hathor shall not be given up yet.

@infograf768 I am busy with another thing now, but if this PR here is ready for the final test, e.g. location column removed, let me know and I help with the test.

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Feb 2016

ok. so why not invest resources in making isis total accessible (WCAG 2.0 AAA), instead of wasting resources with hathor?

@infograf768 sorry to hijack the PR.

avatar richard67
richard67 - comment - 22 Feb 2016

@andrepereiradasilva Was all already discussed in another PR a few weeks ago, just don't remember now which one. I also don't remember what the conclusion was, if Hathor will be dropped and Isis be accessible before 4.0 or if all will change anyway then. Sure making Isis accessible is the best way.

avatar infograf768
infograf768 - comment - 22 Feb 2016

Location column gone. :)

avatar richard67
richard67 - comment - 22 Feb 2016

@infograf768 Means ready for test?

avatar infograf768
infograf768 - comment - 22 Feb 2016

yep

avatar richard67
richard67 - comment - 22 Feb 2016

Ok, but it may take a while until I can test. I have messed up my test system with other stuff and so cannot test on current staging + this PR now. It may need a few hours.

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Feb 2016

@infograf768 when i submit a default language change i get redirected to "...&client=".

Could you just remove the last "&client=" from https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_languages/controllers/installed.php#L54?

avatar infograf768
infograf768 - comment - 22 Feb 2016

@andrepereiradasilva
I get index.php?option=com_languages&view=installed&client=1 or 0

It is unrelated to this patch for Hathor and does not break anything. Let's not mix stuff.

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Feb 2016

ok sure.

avatar andrepereiradasilva andrepereiradasilva - test_item - 22 Feb 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Feb 2016

I have tested this item :white_check_mark: successfully on d8ef3e6

Then is tested.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9190.

avatar richard67 richard67 - test_item - 22 Feb 2016 - Tested successfully
avatar richard67
richard67 - comment - 22 Feb 2016

I have tested this item :white_check_mark: successfully on d8ef3e6


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9190.

avatar infograf768 infograf768 - change - 22 Feb 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 22 Feb 2016

rtc. thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9190.

avatar joomla-cms-bot joomla-cms-bot - change - 22 Feb 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 23 Feb 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-02-23 11:01:37
Closed_By wilsonge
avatar wilsonge wilsonge - close - 23 Feb 2016
avatar joomla-cms-bot joomla-cms-bot - close - 23 Feb 2016
avatar joomla-cms-bot joomla-cms-bot - change - 23 Feb 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment