[#9142] - Move h2 inside if statement
- Closed
- 17 Feb 2016
- Medium
- Build: staging
- Easy Test
- # 9142
- Diff
- brianteeman:h2
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Remove empty h2 tag if Show_article set to hide
Steps to reproduce the issue
Create an single with following article properties :
show_article : hide
show_author : show
Before PR
An empty h2 tag is added to the code rendered
After PR
No tag present
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Front End |
| Rel_Number | 0 | ⇒ | 7790 |
| Relation Type | ⇒ | Pull Request for | |
| Easy | No | ⇒ | Yes |
ignore previous comment
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9142.
I have tested this item 
successfully on fc651bb
Tested with success, despite of the incorrect test instructions, which should be as follows (changed or inserted stuff in capitals):
Create an single ARTICLE MENU ITEM with following article properties :
show_TITLE : hide
show_author : show
Also important for testing is not to use any template overrides for the single article view.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9142.
Hmm, after I had set my test result her at the issue tracker, the previous test result from rehrumesh disappeared from the list and the counter here.
Also in the PR on GitHub only 1 successful test is counted.
But this PR should have 2 successful tests now.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9142.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-17 21:54:14 |
| Closed_By | ⇒ | wilsonge |
| Labels |
Removed:
?
|
||
| Milestone |
Added: |
||
Merged - thanks Brian!
I have tested this item successfully on fc651bb
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9142.
Earlier I hadn't use the JTracker application. So marked it again using JTracker.
#771
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9142.