I couldnt repeat the issue so have not been able to test the patch

I followed all the steps above and in step 3 I added the following at the very top of the sql

this is a comment

I then proceeded as above with step 4 but ALL the sql in the administrator/sql/install.mysql.utf8.sql were processed

Did I do something wrong?

oops markdown modified what I wrote
# this is a comment

I have tested this item successfully on 1ef6317

I tested it successfully with DPCalendar.

Brian, have you tried to install a fresh component or have you tried to update it? To replicate the issue you must install a component that is not already installed.

I can provide a modified DPCalendar version if needed to test.

it was a clean web site installed just for this test using the current
staging

On 17 February 2016 at 12:36, Allon Moritz notifications@github.com wrote:

I can provide a modified DPCalendar version if needed to test.

—
Reply to this email directly or view it on GitHub
#9137 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Tested again using DPCalendar where I added
# this is a comment
to the very first line of /com_dpcalendar/admin/sql/install.mysql.utf8.sql

Again had no problem at all

I have tested this item unsuccessfully on 1ef6317

Brian, if you test the issue with DPCalendar by adding a comment to the very first line of com_dpcalendar/admin/sql/install.mysql.utf8.sql the installer works ok, but the component not. Just after installing, go to Components->DP Calendar->Events and you'll get the following SQL error:

#__dpcalendar_events' doesn't exist SQL=SELECT u.id AS value, u.name AS text FROM #__users AS u INNER JOIN #__dpcalendar_events AS c ON c.created_by = u.id GROUP BY u.id, u.name ORDER BY u.name

This is because the events table is missing in your database.

Ah I tested the other views in dpcalendar and they were ok. They were all
OK in my own component.
On 17 Feb 2016 1:40 pm, "Juan" notifications@github.com wrote:

Brian, if you test the issue with DPCalendar by adding a comment to the
very first line of com_dpcalendar/admin/sql/install.mysql.utf8.sql the
installer works ok, but the component not. Just after installing, go to
Components->DP Calendar->Events and you'll get the following SQL error:

#__dpcalendar_events' doesn't exist SQL=SELECT u.id AS value, u.name AS
text FROM #__users AS u INNER JOIN #__dpcalendar_events AS c ON
c.created_by = u.id GROUP BY u.id, u.name ORDER BY u.name

This is because the events table is missing in your database.

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/9137
https://issues.joomla.org/tracker/joomla-cms/9137.

—
Reply to this email directly or view it on GitHub
#9137 (comment).

I have tested this item successfully on 1ef6317

Got it now - sorry for confusion
I thought you meant that evetything after the comment would be ignored when you meant the first thing after the comment

RTC

Merged