User tests: Successful: Unsuccessful:
Fix scrolling inside bootstrap modals (small height of window viewport: mobile, window resized...).
Corrects the media modal padding on small devices.
Isis template
In admin test new bootstrap modals introduced in 3.5.0 beta2 :
Protostar template
In frontend :
We should be able to scroll inside the modal, and use all options when using administration on a mobile or small screen device.
You may not be able to scroll the modal on iOS (iPhone) (tests on other mobile OS are welcome!)
On window resized (small height), modal could be off screen (bottom content not accessible)
BEFORE PATCH on iPhone 4S iOS 9.2.1
Modal off screen. Not possible to scroll.
Scrolling not working on mobile is a known issue of Bootstrap modals, not fixed in BS 2 and 3 : twbs/bootstrap#14839 (and maybe related to a webkit bug: https://bugs.webkit.org/show_bug.cgi?id=153856)
To set a max-height for modal-body class depending on the current viewport height solves the issue of not being able to view bottom of the modal window. (resize your window to arround 300px height before and after patch)
Apply the patch, and you may be able to scroll inside all bootstrap modals.
AFTER PATCH on iPhone 4S iOS 9.2.1
Modal adapts to screen. Scroll is working.
Note: Review of the comments by a native English speaker will be appreciated ;-)
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Title |
|
PR now updated for Protostar, and ready for testing! ;-)
Labels |
Added:
?
|
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-17 14:27:51 |
Closed_By | ⇒ | JoomliC |
Title |
|
Thanks to first feedback from @dgt41 ( ) i will update tomorrow this PR with protostar css fix, and more testing instruction with screen shots before/after patch.