? Success

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
12 Feb 2016

Here is alternative version of that pull request #8867

test
Enable Captcha for the contact form.
Then add in the Contact description:

<div class="g-recaptcha" data-sitekey="ENTER_HERE_SITEKEY" 
  data-theme="light" data-size="compact"></div>

In result you should be able to see 2 captcha on the page. One under the form and second in the contact description.

avatar Fedik Fedik - open - 12 Feb 2016
avatar Fedik Fedik - change - 12 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2016
Labels Added: ?
avatar 810
810 - comment - 12 Feb 2016

i still get:
This reCAPTCHA is currently running on localhost.
recaptcha status
Verification expired, select the checkbox again for a new challenge
Verification expired. Check the checkbox again

will try a new branch tonight

avatar andrepereiradasilva andrepereiradasilva - test_item - 12 Feb 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Feb 2016

I have tested this item :white_check_mark: successfully on 2c98a7a

Tested successfully by adding a two recaptcha form fields in /components/com_users/models/forms/remind.xml (URI: /component/users/?view=remind)
Also tested adding the following HTML to the remind view:

Custom 1: <div class="g-recaptcha" data-sitekey="ENTER_HERE_SITEKEY" data-theme="light" data-size="compact"></div><br/>
Custom 2: <div class="g-recaptcha" data-sitekey="ENTER_HERE_SITEKEY" data-theme="light"></div><br/>
Custom 3: <div class="g-recaptcha" data-sitekey="ENTER_HERE_SITEKEY" data-size="compact"></div><br/>
Custom 4: <div class="g-recaptcha" data-sitekey="ENTER_HERE_SITEKEY"></div><br/>

All worked.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9111.

Update: I didn't test the submit, only the captcha js loading.

avatar 810 810 - test_item - 12 Feb 2016 - Tested successfully
avatar 810
810 - comment - 12 Feb 2016

I have tested this item :white_check_mark: successfully on 2c98a7a

Test is ok, only i need to crtl + f5 to refresh, then i see the recaptcha again, else users can send the form again without the captcha check.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9111.

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Feb 2016

@Fedik just one thing, can you make a min js file and call that one?
Also check the tabs on the copyright

avatar Fedik
Fedik - comment - 12 Feb 2016

@andrepereiradasilva yes, if it need :smile:
I will try tomorrow,

avatar joomla-cms-bot
joomla-cms-bot - comment - 13 Feb 2016

This PR has received new commits.

CC: @810, @andrepereiradasilva


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9111.

avatar Fedik
Fedik - comment - 13 Feb 2016

added minified version, please retest

avatar andrepereiradasilva andrepereiradasilva - test_item - 13 Feb 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 13 Feb 2016

I have tested this item :white_check_mark: successfully on d8a7b53


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9111.

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Feb 2016

@810 can you retest this so if mantainers agree can go to 3.5.0?

avatar 810 810 - test_item - 16 Feb 2016 - Tested successfully
avatar 810
810 - comment - 16 Feb 2016

I have tested this item :white_check_mark: successfully on d8a7b53


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9111.

avatar 810
810 - comment - 16 Feb 2016

@joomla-cms-bot can be RTC

avatar dgt41 dgt41 - change - 16 Feb 2016
Status Pending Ready to Commit
avatar dgt41
dgt41 - comment - 16 Feb 2016

@810 just calling the bot won't automatically label the PR as RTC, someone has to set that in the issue tracker


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9111.

avatar joomla-cms-bot joomla-cms-bot - change - 16 Feb 2016
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Feb 2016

i already said the bot needs some AI :)

avatar 810
810 - comment - 16 Feb 2016

@dgt41 but he is now alive ;)

avatar dgt41
dgt41 - comment - 16 Feb 2016

@810 with a little help...

@andrepereiradasilva Jesus (????) is here: https://github.com/joomla/jissues

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Feb 2016

Well, let's hope this can be merged before 3.5.0

@joomla-cms-bot merge this :D

avatar Kubik-Rubik Kubik-Rubik - change - 18 Feb 2016
Milestone Added:
avatar Kubik-Rubik
Kubik-Rubik - comment - 18 Feb 2016

Thank you @Fedik and testers!

avatar Kubik-Rubik Kubik-Rubik - change - 18 Feb 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-02-18 08:44:39
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 18 Feb 2016
avatar joomla-cms-bot joomla-cms-bot - close - 18 Feb 2016
avatar Kubik-Rubik Kubik-Rubik - reference | f7e4ce5 - 18 Feb 16
avatar Kubik-Rubik Kubik-Rubik - merge - 18 Feb 2016
avatar Kubik-Rubik Kubik-Rubik - close - 18 Feb 2016
avatar joomla-cms-bot joomla-cms-bot - change - 18 Feb 2016
Labels Removed: ?
avatar Fedik Fedik - head_ref_deleted - 18 Feb 2016

Add a Comment

Login with GitHub to post a comment