? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
11 Feb 2016

Description

This PR adds, for consistency, as it exists in so many other views in the backoffice, the order select box of the search tools to com_installer updatesites view.

Also corrects bug where the folder filter and not selecting the search button, and other small graphical issues.
Also other small code changes/improvements.

Before PR

com_installer-updatesites-beforepr

After PR

com_installer-updatesites-afterpr

How to test

  1. Install latest staging and apply this patch
  2. Go to Extensions -> Manage -> Update Sites
  3. Check the ordering select box and the filter are working fine.
avatar andrepereiradasilva andrepereiradasilva - open - 11 Feb 2016
avatar andrepereiradasilva andrepereiradasilva - change - 11 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Feb 2016
Labels Added: ? ?
avatar richard67 richard67 - test_item - 12 Feb 2016 - Tested successfully
avatar richard67
richard67 - comment - 12 Feb 2016

I have tested this item :white_check_mark: successfully on 0eb1742

Tested with success, ordering and filtering works fine, and the page looks well.

"Also corrects bug where order by name descending was not working" - this I could not verify: Here it worked well before and after the patch.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9107.

avatar richard67
richard67 - comment - 12 Feb 2016

P.S.: The "folder filter and not selecting the search button" thing I could verify with success: After selecting the folder as only filter, the search tools are hidden without the patch of this PR, and with the patch they stay visible as it should be.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9107.

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Feb 2016

"Also corrects bug where order by name descending was not working" - this I could not verify: Here it worked well before and after the patch.

Sorry copy/paste from other PR. I updated the description

avatar ghazal ghazal - test_item - 12 Feb 2016 - Tested successfully
avatar ghazal
ghazal - comment - 12 Feb 2016

I have tested this item :white_check_mark: successfully on 0eb1742


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9107.

avatar brianteeman brianteeman - change - 12 Feb 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 12 Feb 2016

RTC thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9107.

avatar joomla-cms-bot joomla-cms-bot - change - 12 Feb 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 14 Feb 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-02-14 19:31:02
Closed_By wilsonge
avatar wilsonge wilsonge - reference | 393af26 - 14 Feb 16
avatar wilsonge wilsonge - merge - 14 Feb 2016
avatar wilsonge wilsonge - close - 14 Feb 2016
avatar wilsonge
wilsonge - comment - 14 Feb 2016

Merged - thanks all!

avatar joomla-cms-bot joomla-cms-bot - change - 14 Feb 2016
Labels Removed: ?
avatar wilsonge wilsonge - change - 14 Feb 2016
Milestone Added:
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 14 Feb 2016

Add a Comment

Login with GitHub to post a comment