? Success

User tests: Successful: Unsuccessful:

avatar ot2sen
ot2sen
11 Feb 2016

… selected and all info box items set to not show.

avatar ot2sen ot2sen - open - 11 Feb 2016
avatar ot2sen ot2sen - change - 11 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Feb 2016
Labels Added: ?
avatar sovainfo
sovainfo - comment - 11 Feb 2016

To avoid showing tags both above and below suggest to use the code below instead:

<?php if ($info == 1 || $info == 2)) : ?>
<?php if ($useDefList) : ?>
<?php echo JLayoutHelper::render('joomla.content.info_block.block', array('item' => $this->item, 'params' => $params, 'position' => 'below')); ?>
<?php endif; ?>

<?php if ($params->get('show_tags', 1) && !empty($this->item->tags->itemTags)) : ?>
<?php $this->item->tagLayout = new JLayoutFile('joomla.content.tags'); ?>
<?php echo $this->item->tagLayout->render($this->item->tags->itemTags); ?>
<?php endif; ?>
<?php endif; ?>

Obviously, it must be properly indented, strangely enough it is to difficult for github to respect indentation in the code.

avatar brianteeman brianteeman - change - 15 Feb 2016
Category Tags
avatar brianteeman
brianteeman - comment - 15 Feb 2016

Please update with full testing instructions


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9105.

avatar sovainfo
sovainfo - comment - 15 Feb 2016

Test instructions:
Create several tags
Create an article with those tags assigned
Create a menu item for that article
Verify the setting of infoblock as above,split and below
Hide all infoblock settings but tags
Verify the setting of infoblock as above, split and below
When tags are shown as expected depending on above, split and below even when none of the othe settings are shown report an successful test in issues.joomla.org

Note: infoblock set to split means tagsto be shown below.

avatar ot2sen
ot2sen - comment - 15 Feb 2016

Thanks @sovainfo for the suggestion and the testing instructions :)
I was looking at the upper part seeing it was outside the condition but didn´t pay attention to its own condition. Perhaps they should follow same approach and let the lower tags check if info is 1 or 2 similar to checking if it is 0 at top?

Something like:
<?php if ($info == 1 || $info == 2 && $params->get('show_tags', 1) && !empty($this->item->tags->itemTags)) : ?>
<?php $this->item->tagLayout = new JLayoutFile('joomla.content.tags'); ?>

    <?php echo $this->item->tagLayout->render($this->item->tags->itemTags); ?>
<?php endif; ?>
avatar ot2sen
ot2sen - comment - 15 Feb 2016

Sorry, I am slow, you did already add that check. Thanks again :)
Will see if I can redo the PR without getting in conflict

avatar ot2sen
ot2sen - comment - 17 Feb 2016

More detailed testing instructions:

What I did:
1. Set all info box items to off (Hide or No) in the Content->Articles->Options
1.b Set the Option for 'Position of article info' to 'Above'
2. Create an article and set all info box items to use global
3. Create tags and assign to the article
4. Create a menu item, single article, and set info box items to global, and try the 3 different settings for 'Position of article info'
4.1 Set 'Position of article info' to 'Above'
4.2 Set 'Position of article info' to 'Below'
4.3 Set 'Position of article info' to 'Split'

What happened:
For case 4.1 the tags appear at top
For case 4.2 no tags appear
For case 4.3 no tags appear

What should have happened:
For case 4.1 the tags appear at top
For case 4.2 the tags appear below
For case 4.3 the tags appear below

Apply the patch and you should see this happen now.

Other information:
Issue has been reported in forum and fb group more times and also reported in the following issue
#8438

avatar genesisfan
genesisfan - comment - 18 Feb 2016

@test successfully tested.
9105

thanks @ot2sen for the detailed test instructions.

avatar ot2sen
ot2sen - comment - 19 Feb 2016

Thanks for testing @genesisfan :)

Perhaps you should also login to https://issues.joomla.org/tracker/joomla-cms/9105 and have the successful test recorded using the 'Test' button, to have it show that there is 1 successful test now.
See: https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results

avatar brianteeman brianteeman - alter_testresult - 19 Feb 2016 - genesisfan: Tested successfully
avatar brianteeman
brianteeman - comment - 19 Feb 2016

@ot2sen I just manually marked @genesisfan as a successful test


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9105.

avatar ot2sen
ot2sen - comment - 19 Feb 2016

Thanks @brianteeman

avatar brianteeman brianteeman - test_item - 19 Feb 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 19 Feb 2016

I have tested this item :white_check_mark: successfully on 74cf84e

Took me a while to work this out as it worked ok if you had author or category set to show but I can now confirm the issue and the fix - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9105.

avatar brianteeman brianteeman - change - 19 Feb 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 19 Feb 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9105.

avatar joomla-cms-bot joomla-cms-bot - change - 19 Feb 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 23 Feb 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-02-23 21:55:18
Closed_By wilsonge
avatar wilsonge wilsonge - close - 23 Feb 2016
avatar joomla-cms-bot joomla-cms-bot - close - 23 Feb 2016
avatar wilsonge wilsonge - reference | 8691720 - 23 Feb 16
avatar wilsonge wilsonge - merge - 23 Feb 2016
avatar wilsonge wilsonge - close - 23 Feb 2016
avatar joomla-cms-bot joomla-cms-bot - change - 23 Feb 2016
Labels Removed: ?
avatar wilsonge wilsonge - change - 23 Feb 2016
Milestone Added:
avatar wilsonge
wilsonge - comment - 23 Feb 2016

Mreged - thanks!

Add a Comment

Login with GitHub to post a comment