[#9099] - com_languages languages view, ordering in searchtools
- Closed
- 15 Feb 2016
- Medium
- Build: staging
- # 9099
- Diff
- andrepereiradasilva:com_languages-languages-searchtools-improv
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Description
This PR adds, for consistency, as it exists in so many other views in the backoffice, the order select box of the search tools to com_languages content languages view.
Also corrects some code issues and adds Home ordering.
And other small code changes/improvements.
Before PR
After PR
How to test
- Install latest staging and apply this patch
- Go to Extensions -> Languages -> Content languages
- Check the ordering select box and the filter are working fine.
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
?
|
||
I have tested this item 
successfully on b5cd1b8
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9099.
This PR has received new commits.
CC: @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9099.
Done
I have tested this item successfully on cf0d882
Tested with success.
Latest change also tested for RTL with admin language = Arabic. Flag comes before the prefix, i.e. when LTR left and when RTL right beside prefix. Looks really much better than before.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9099.
I have tested this item successfully on cf0d882
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9099.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC - thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9099.
| Labels |
Added:
?
|
||
"Archived" is not possible for Content Languages. This was also present before this patch.
Can you correct this here and change the filter_languages.xml to
<field
name="published"
type="status"
filter="*,-2,0,1"
onchange="this.form.submit();"
>
<option value="">JOPTION_SELECT_PUBLISHED</option>
</field>
@infograf768 thanks for the comments. Will correct the issue later.
This PR has received new commits.
CC: @brianteeman, @richard67
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9099.
@infograf768 archive removed and now mobile friendly.
@brianteeman @richard67 Can you retest?
I have tested this item successfully on afec57a
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9099.
I have tested this item successfully on afec57a
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9099.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-15 14:31:00 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
Merged - thanks guys!
| Labels |
Removed:
?
|
||
Hmm, would look better if the flags were in case of current admin language direction LTR left and in case of RTL right beside the image prefix, so in the screenshots above with LTR left beside the image prefix.
I know it was same ugly before and after this PR, but if you agree and easily can change that ... can you check?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9099.