? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
10 Feb 2016

Adds the missing flags for Norwegian Nynorsk nn-NO and Uyghur ug-CN
Correcting uppercase for Sinhala si-LK

avatar infograf768 infograf768 - open - 10 Feb 2016
avatar infograf768 infograf768 - change - 10 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Feb 2016
Labels Added: ?
avatar infograf768
infograf768 - comment - 10 Feb 2016

can be merged on review.
@Bakual
@wilsonge

Thanks.

avatar wilsonge wilsonge - change - 10 Feb 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-02-10 13:42:43
Closed_By wilsonge
avatar wilsonge wilsonge - close - 10 Feb 2016
avatar wilsonge wilsonge - reference | 40733b4 - 10 Feb 16
avatar wilsonge wilsonge - merge - 10 Feb 2016
avatar wilsonge wilsonge - close - 10 Feb 2016
avatar wilsonge
wilsonge - comment - 10 Feb 2016

I'm slightly nervous about case changing on different file systems (remember that horrible bug we had with the composer classLoader file a few versions ago). But merging.

avatar infograf768
infograf768 - comment - 10 Feb 2016

No worry, @wilsonge
As stated in #9089 (comment) the Uppercase created an issue. We do need that file to be named the same as other language flags gif.
it was a mistake when the gif was added (by me...).
2a9cbce#diff-d2ee215aba9b60e460d748888ef10ffb

avatar Bakual
Bakual - comment - 10 Feb 2016

@wilsonge Shouldn't be an issue here. Worst case is we get two flags on linux systems, one uppercase and one lowercase. But the uppercased one will not create any troubles at all. It's just a bit of unneeded webspace used.
It's not like we autoload the flags like we do with classes :smile:

Add a Comment

Login with GitHub to post a comment