? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
9 Feb 2016

Description

This PR adds, for consistency, as it exists in so many other views in the backoffice, the order select box of the search tools to com_users notes.

Also corrects the bug that made search tools has always selected (open), even if no filter has selected and the pre-selected ordering has different in the xml and in the php.

And other small code changes.

Before PR

image

After PR

image

How to test

  1. Install latest staging and apply this patch
  2. Go to Users -> User Notes
  3. Check the ordering select box and the filter are working fine.
  4. Check in the modal view too (create some notes for a user and then go to user list and there is a button to view user notes).
avatar andrepereiradasilva andrepereiradasilva - open - 9 Feb 2016
avatar andrepereiradasilva andrepereiradasilva - change - 9 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2016
Labels Added: ? ?
avatar andrepereiradasilva andrepereiradasilva - change - 9 Feb 2016
The description was changed
avatar richard67 richard67 - test_item - 10 Feb 2016 - Tested successfully
avatar richard67
richard67 - comment - 10 Feb 2016

I have tested this item :white_check_mark: successfully on fac0992


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9091.

avatar brianteeman brianteeman - test_item - 11 Feb 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 11 Feb 2016

I have tested this item :white_check_mark: successfully on fac0992


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9091.

avatar brianteeman brianteeman - change - 11 Feb 2016
Status Pending Ready to Commit
Labels
avatar brianteeman
brianteeman - comment - 11 Feb 2016

RTC - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9091.

avatar joomla-cms-bot joomla-cms-bot - change - 11 Feb 2016
Labels Added: ?
avatar wilsonge wilsonge - change - 18 Feb 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-02-18 10:14:57
Closed_By wilsonge
avatar wilsonge wilsonge - reference | 22c0cf4 - 18 Feb 16
avatar wilsonge wilsonge - merge - 18 Feb 2016
avatar wilsonge wilsonge - close - 18 Feb 2016
avatar wilsonge wilsonge - change - 18 Feb 2016
Milestone Added:
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 18 Feb 2016
avatar brianteeman brianteeman - change - 11 May 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment