? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
8 Feb 2016

Description

PR #9077 added chosen style in mod languages.
But it added even if there is no select box.

This corrects that

How to test

  1. Install latest staging with Multilanguage with language switcher flags.
  2. Open any page and check source code. There is a chosen css in all pages.
  3. Apply PR. There is no chosen css now.
  4. Chosen will still apply with mod_languages with option selector

@infograf768 please check

avatar andrepereiradasilva andrepereiradasilva - open - 8 Feb 2016
avatar andrepereiradasilva andrepereiradasilva - change - 8 Feb 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Feb 2016
Labels Added: ?
avatar dgt41 dgt41 - test_item - 8 Feb 2016 - Tested successfully
avatar dgt41
dgt41 - comment - 8 Feb 2016

I have tested this item :white_check_mark: successfully on 246e145

I agree with this change!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9087.

avatar infograf768 infograf768 - test_item - 9 Feb 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 9 Feb 2016

I have tested this item :white_check_mark: successfully on 246e145


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9087.

avatar infograf768 infograf768 - change - 9 Feb 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 9 Feb 2016

Agree indeed. RTC. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9087.

avatar joomla-cms-bot joomla-cms-bot - change - 9 Feb 2016
Labels Added: ?
avatar infograf768
infograf768 - comment - 10 Feb 2016

@wilsonge

Please merge in 3.5.0

avatar wilsonge wilsonge - reference | 6a9ab65 - 10 Feb 16
avatar wilsonge wilsonge - merge - 10 Feb 2016
avatar wilsonge wilsonge - close - 10 Feb 2016
avatar wilsonge wilsonge - change - 10 Feb 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-02-10 10:50:08
Closed_By wilsonge
avatar wilsonge wilsonge - close - 10 Feb 2016
avatar joomla-cms-bot joomla-cms-bot - close - 10 Feb 2016
avatar joomla-cms-bot joomla-cms-bot - change - 10 Feb 2016
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 27 Feb 2016

Add a Comment

Login with GitHub to post a comment