Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#9080] - SEF system plugin performance improvements

? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
6 Feb 2016

Description

This PR does some performance improvements to the SEF system plugin.

Before PR

sef-before-pr

After PR

sef-after-pr

How to test

  1. Enable SEF in global config and enable SEF system plugin
  2. Create some content with links, images, objects, etc. (see code to see what this plugin replaces)
  3. Apply this patch
  4. Check if all links and references (ex: images) are using the SEF uri as before.

For checking the performance improvements:

JDEBUG && $this->_observers[$key] == 'PlgSystemSef' ? JProfiler::getInstance('Application')->mark('- ' . $this->_observers[$key] . '->' . $event . ' started.') : null;
$value = $this->_observers[$key]->update($args);
JDEBUG && $this->_observers[$key] == 'PlgSystemSef' ? JProfiler::getInstance('Application')->mark('- <strong>' . $this->_observers[$key] . '->' . $event . ' Ended!</strong>') : null;
  • Check the profile information in the debug console before and after PR

Notes:

  • The more code a page has, the more time the onAfterRender event of the SEF plugin will take. So test this in category blog views and other pages with lot of content.
  • It would be good to test in ready to production sites, i.e., with real content.

Observations

Suggestions, code reviews and improvements are welcomed.

avatar andrepereiradasilva andrepereiradasilva - open - 6 Feb 2016
avatar andrepereiradasilva andrepereiradasilva - change - 6 Feb 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Feb 2016
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 8 Feb 2016

BTW i have a production site (3.4.8) that, by just applying this PR i get a performance improvement in almost all pages of ~45ms (around 10%).

Before PR
image

After PR
image

So the performance improvement largely depends of the HTML code of the pages.

avatar dgt41 dgt41 - test_item - 8 Feb 2016 - Tested successfully
avatar dgt41
dgt41 - comment - 8 Feb 2016

I have tested this item :white_check_mark: successfully on 42d86c0

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9080.

avatar waader waader - test_item - 13 Feb 2016 - Tested successfully
avatar waader
waader - comment - 13 Feb 2016

I have tested this item :white_check_mark: successfully on 42d86c0

I also tested this on a production site (3.4.8) with a lot of content, different menu types and different components and I can see similar improvements.

Thanks!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9080.

avatar brianteeman brianteeman - change - 15 Feb 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 15 Feb 2016

Thanks for testing - setting RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9080.

avatar joomla-cms-bot joomla-cms-bot - change - 15 Feb 2016
Labels Added: ?
avatar roland-d roland-d - change - 16 Feb 2016
Milestone Added:
avatar roland-d roland-d - reference | 02a65e6 - 16 Feb 16
avatar roland-d roland-d - merge - 16 Feb 2016
avatar roland-d roland-d - close - 16 Feb 2016
avatar roland-d roland-d - change - 16 Feb 2016
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-02-16 17:32:53
Closed_By ⇒ roland-d
avatar roland-d roland-d - close - 16 Feb 2016
avatar joomla-cms-bot joomla-cms-bot - close - 16 Feb 2016
avatar joomla-cms-bot joomla-cms-bot - change - 16 Feb 2016
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 27 Feb 2016

Add a Comment

Login with GitHub to post a comment