[#9068] - Use language item instead of hardcoded string
- Closed
- 18 Feb 2016
- Medium
- Build: staging
- # 9068
- Diff
- joomdonation:patch-7
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This is just a small PR which change the text of state dropdown (generated by JHtmlGrid::state method) from a text to a language item
We have language items JPUBLISHED, JUNPUBLISHED and I think we should use it instead of Published and Unpublished string at the moment.
I found this issue while supporting a customer site. His site language is Italian but when I used JHtmlGrid::state('published'), that English text Published and Unpublished are not translated.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Language & Strings Libraries |
If I knew where to find a state dropdown where this problem occurs, or which code snippet to use to generate such if it is not in standard backend or frontent templates somewhere, then I could test this PR, too.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9068.
Thanks Richard. Just add this code to administrator/components/com_content/content.php for example.
echo JHtmlGrid::state();Check and make sure:
For English language, before and after patch, the dropdown generated by the above command is the same
For Italia language (maybe for other languages), before patch, the text Published and Unpublished in the dropdown is not translated. After patch, these text is translated to Italia language
I have tested this item 
successfully on dd87b1c
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9068.
| Status | Pending | ⇒ | Ready to Commit |
Thanks for testing - setting RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9068.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
Thank you @joomdonation and testers!
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-18 08:47:44 |
| Closed_By | ⇒ | Kubik-Rubik |
| Labels |
Removed:
?
|
||
I have tested this item
successfully on dd87b1c
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9068.