[#9054] - [REGRESSION] sort order
- Closed
- 3 Feb 2016
- Medium
- Build: master
- # 9054
Steps to reproduce the issue
Log out and clear all cookies
Log back in and go to plugin manager. You will see all the plugins sorted by Type Ascending as shown by the arrow not Type Descending as shown by the dropdown select
Scroll to the bottom and click 2 on the pagination
Now you will see all the plugins sorted by Type Descending as shown by the arrow AND by the dropdown select
Not tested but I suspect ALL manager views have the same/similar bug where the default value in the dropdown doesnt match the default value in the column headers which is what (i think) is causing the problem - @pe7er I think this was a PR you did?
We have PR for
Plugins #9060
Modules #9059
Contacts #9057
Newsfeeds #9056
Thanks @bertmert can you do one for featured as well ?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9054.
See PRs please and test.
For featured we need a decision first.
Featured uses function populateState of model ContentModelArticles. There default ordering is hard coded (I don't know why)
parent::populateState('a.id', 'desc');
Shall Featured from now on be ordered also by id descending or by title ascending?
In both cases we have to change featured model.or both models.
For featured I would personally go for ordering but I dont really care as long as both settings are the same and we dont get this pagination bug
OK, I will see how to manage it.
I just made some quick tests with other PRs. I hope they work.
Already tested them - theyre great
Closing as we have PRs - thanks!!!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9054.
@brianteeman You forgot to close this? ;-)
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-03 13:39:17 |
| Closed_By | ⇒ | brianteeman |
@brianteeman I was a week off-the-grid due to the flu.
Yeah, it might have been caused by my PRs. Sorry...
@bertmert Thanks for your PRs!
Hope you are better now -- you must have caught something at Fosdem. See
you next weekend
On 6 February 2016 at 13:25, Peter Martin notifications@github.com wrote:
@brianteeman https://github.com/brianteeman I was a week off-the-grid
due to the flu.
Yeah, it might have been caused by my PRs. Sorry...@bertmert https://github.com/bertmert Thanks for your PRs!
—
Reply to this email directly or view it on GitHub
#9054 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Full List
Plugins
Switches from Type Ascending to Type Descending
Modules
Switches from Position Ascending to Ordering Ascending
Featured
Switches from ID Descending to Title Ascending
Contacts
Switches from Title Ascending to ID Descending
Newsfeeds
Switches from Title Ascending to ID Descending