Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#9046] - Add support for URLs with no protocol in JDocumentRenderer

? Success
Pull Request for # 9039

User tests: Successful: Unsuccessful:

avatar wojsmol
wojsmol
2 Feb 2016

Fix for #9039

Orgiinal issue description

Steps to reproduce the issue

Create an article with text containing a URL with no protocol. A good example could be an embed of a dailymotion video which contains no protocol in the iframe src of the embed code. Then try to view a feed containing that article.

Expected result

The expected result is that the iframe src is not modified.

Actual result

Joomla tries to replace all relative links to absolute links in feeds. The function _relToAbs of JDocumentRenderer class considers incorrectly that URLs with no protocol are relative links and prepends the site's absolute URL to them.

System information (as much as possible)

Checked under Joomla! 3.4.8 and 3.5 BETA 2.

Additional commments

avatar wojsmol wojsmol - open - 2 Feb 2016
avatar wojsmol wojsmol - change - 2 Feb 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Feb 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 2 Feb 2016
Rel_Number 0 ⇒ 9039
Relation Type ⇒ Pull Request for
avatar anibalsanchez anibalsanchez - test_item - 5 Feb 2016 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 5 Feb 2016

I have tested this item :white_check_mark: successfully on 955d74b

Test OK

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9046.

avatar brianteeman brianteeman - change - 1 Mar 2016
Category ⇒ Libraries
avatar SharkyKZ SharkyKZ - test_item - 10 Mar 2016 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 10 Mar 2016

I have tested this item :white_check_mark: successfully on 955d74b

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9046.

avatar brianteeman brianteeman - change - 30 Mar 2016
Status Pending ⇒ Ready to Commit
avatar brianteeman
brianteeman - comment - 30 Mar 2016

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9046.

avatar joomla-cms-bot joomla-cms-bot - change - 30 Mar 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 30 Mar 2016
Milestone Added:
avatar rdeutz rdeutz - reference | 95fb3bf - 12 Apr 16
avatar rdeutz rdeutz - merge - 12 Apr 2016
avatar rdeutz rdeutz - close - 12 Apr 2016
avatar rdeutz rdeutz - change - 12 Apr 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-04-12 19:14:22
Closed_By ⇒ rdeutz
avatar rdeutz rdeutz - close - 12 Apr 2016
avatar rdeutz rdeutz - merge - 12 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - close - 12 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 12 Apr 2016
Labels Removed: ?
avatar wojsmol wojsmol - head_ref_deleted - 12 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Removed:

Add a Comment

Login with GitHub to post a comment