There are a few code style fixes required. See the Travis checks for details.

It would be great if you could supply some sample code so that people can test this easier.

We don't require the mb php extension here so we need to find a work around for these users (I guess even a function_exists will do in a worst case). StringHelper::is_ascii might work?

@brianteeman Ok, will do that.
Sorry, it is the first time for me to post on joomla repo.

Hello @mabdelaziz77

Thank you for your contribution.

The last comment here was on 2nd February. Could you update the pull request with the needed changes as pointed out by @wilsonge
If no reply is received within 4 weeks we will close this issue.

Thanks for understanding!

Hello @roland-d
I will try to find a workaround.
Thanks @wilsonge for your advice.

Thank you

@mabdelaziz77 Thank you for your answer. Does this mean we can close this request or you will try to find another solution and update this request?

The original commit used mb_*:

b96165a

but then it was changed to use:

if (utf8_is_valid($status))

15772dc

so mbstring dependency was removed
does the new code work ?

Sorry, it was long time since I made this pull request.
mbstring dependency was already removed as @ggppdk noticed, and the commit message on Feb 2 declared this removal.

@mabdelaziz77 could you please fix the conflict in libraries/joomla/twitter/statuses.php. Is the code ready for testing or are additional changes coming, not really clear for me at the moment.

If this is still a valid issue the code should be updated to call \Joomla\String\StringHelper::valid() versus utf8_is_valid() directly. Also, since this package is deprecated in the CMS, the corresponding Framework package should be checked and a PR issued there with the same fix.

If this PR get no Response, it will be closed at 22th June 2017.

closed as stated above.

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/9044