Feeling Lucky
?
[#9042] - Move getCurrentLanguage() to JLanguageHelper
- Closed
- 5 Sep 2016
- Medium
- Build: staging
- # 9042
- Diff
- andrepereiradasilva:movo-to-jlanguagehelper
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Description
This PR moves JHelper->getCurrentLanguage() and JHelperContent::getCurrentLanguage() to JLanguageHelper::getCurrentLanguage(), deprecates the old methods and replaces them where they are currently being used.
How to test
- Use a joomla multilanguage site and apply this patch
- Add tags in several languages
- Add those tags to a content
- Go to tags component (com_tags) options and in "Item selection" -> "Language Filter" select "Current"
- Go to frontend and check that the tags that are displayed in the content are only those in the current language and the ones with all languages
- Check also the same behaviour for the tags in the modules (mod_tags_popular and mod_tags_similar)
In conclusion, all should work as before.
@joomdonation here you have it.
@mbabker if ok for you, IMHO this should also be done in joomla framework (language).
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Title |
|
||||||
| Title |
|
||||||
andrepereiradasilva
- comment
- 1 Feb 2016
Ok, i see. There must be total separation in the framework, of course.
I noticed now that the joomla language framework (https://github.com/joomla-framework/language/tree/master/src) doesn't even have an helper class.
brianteeman
- | Category | ⇒ | Libraries |
andrepereiradasilva
- comment
- 5 Sep 2016
closed because lack of interrest
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-09-05 22:08:25 |
| Closed_By | ⇒ | andrepereiradasilva |
| Category | Libraries | ⇒ | Tags Front End Components Libraries Modules |
This isn't a change suitable for the Framework in its current form. Mainly, the Framework doesn't have the notion of components nor does it mandate a use of Joomla's application and input APIs.