[#9037] - Regression User field is not validating
- Closed
- 2 Feb 2016
- Medium
- Build: staging
- # 9037
- Diff
- dgt41:formFields
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
This fixes #8667
Field is hardcoded as disabled and the required option is absent
Also contains some code style fixes for the fields: user, media, contenthistory (the var block comments are unified)
Testing
Create a new User Note
do not select user
Form should not be valid and not therefore not been submitted (but it is)
Apply patch and re do the process
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
|
||
This PR has received new commits.
CC: @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9037.
I have tested this item 
unsuccessfully on 95de262
Almost works - cant be saved but no error displayed - just an empty error div
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9037.
This PR has received new commits.
CC: @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9037.
This PR has received new commits.
CC: @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9037.
I have tested this item 
successfully on 99a3ae1
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9037.
Works now here too.
Can you explain further (maybe with comments):
+if (JText::_('JLIB_FORM_SELECT_USER') == htmlspecialchars($userName, ENT_COMPAT, 'UTF-8'))
+{
+ $userName = "";
+}
+
This PR has received new commits.
CC: @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9037.
@infograf768 is a simple check to invalidate the value of the input. If $userName is "Select User" then we set the value to null, so validation will fail and we will get a message. This only happens in the first time the field is rendered, and a user is not already selected.
| Title |
|
||||||
| Status | Pending | ⇒ | Ready to Commit |
Setting RTC - we have two good tests - thanks @dgt41
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9037.
| Labels |
Added:
?
|
||
| Rel_Number | 0 | ⇒ | 8667 |
| Relation Type | ⇒ | Pull Request for | |
| Labels | |||
| Labels | |||
This PR has received new commits.
CC: @brianteeman
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9037.
For completeness:
If the field is set as required then a user should not be able to unset it. In other words the button no user in the modal should appear only if the field can have no value!
| Labels | |||
| Category | ⇒ | Components |
I have tested this item successfully on 122923c
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9037.
This should go into 3.5.0
I have tested this item successfully on 122923c
Tested with success as described on current staging + this patch.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9037.
Kubik-Rubik
- | Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-02-02 08:36:17 |
| Closed_By | ⇒ | Kubik-Rubik |
| Labels |
Removed:
?
|
||
Maybe we can just leave it as how it is:
Uppercase filter string is used in other places in Joomla core, for example https://github.com/joomla/joomla-cms/blob/staging/components/com_users/controllers/user.php#L38-L42
The docblock of JFilterInput clean methods seems suggest that we use uppper case https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/filter/input.php#L206-L220
@Kubik-Rubik check #9047
I have tested this item
unsuccessfully on a8b0f3f
Didnt work
Applied patch
Selected Add New User Note
Clicked Save
User Note was saved
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9037.