? ? Pending

User tests: Successful: Unsuccessful:

avatar jtherczeg
jtherczeg
30 Jan 2016

PR for #9020 Inappropriate term in User Status admin module.
By the terms used in Who's Online frontend module, I selected the term member.

avatar jtherczeg jtherczeg - open - 30 Jan 2016
avatar jtherczeg jtherczeg - change - 30 Jan 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jan 2016
Labels Added: ? ?
avatar MATsxm MATsxm - test_item - 30 Jan 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 30 Jan 2016

I have tested this item :white_check_mark: successfully on 033ec70

Works as described
@brianteeman I have a vague memory of a previous discussion about this but can not find it.
Perhaps it would have been interesting to see what had been said before?
I would have preferred "Registered" as it is what it really is but it's just a personal point of view


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9030.

avatar brianteeman
brianteeman - comment - 30 Jan 2016

Shouldn't the pr be against the staging branch @bakual

avatar brianteeman
brianteeman - comment - 30 Jan 2016

Personally I would only change it to make sure it matched the description in the module

z9bg

avatar jtherczeg
jtherczeg - comment - 30 Jan 2016

@MATsxm and @brianteeman I was also thinking for a long time which term to choose. "Registered" was my first idea, too, finally I selected "member", because this is used in the Who's Online frontend module.

If you decide to change this, you are allowed. Fact, that this needs to be changed. The major Joomla version and the update of the module would be a good occasion.

avatar brianteeman
brianteeman - comment - 30 Jan 2016

Unfortunately I think language strings have been frozen.
On 30 Jan 2016 4:12 pm, "Jozsef" notifications@github.com wrote:

@MATsxm https://github.com/MATsxm and @brianteeman
https://github.com/brianteeman I was also thinking for a long time
which term to choose. "Registered" was my first idea, too, finally I
selected "member", because this is used in the Who's Online frontend module.

If you decide to change this, you are allowed. Fact, that this needs to be
changed. The major Joomla version and the update of the module would be a
good occasion.


Reply to this email directly or view it on GitHub
#9030 (comment).

avatar Bakual
Bakual - comment - 30 Jan 2016

Shouldn't the pr be against the staging branch

@brianteeman You're right, I didn't check that. If all agree on this change, I can still merge it since it's quite a simple PR.
The language strings are only yet frozen for the installation folder. The others get frozen for the release candidates usually.

avatar infograf768
infograf768 - comment - 30 Jan 2016

OK for me.

avatar brianteeman
brianteeman - comment - 30 Jan 2016

doesnt work for me - the change is no better than the current - which I
agree is misleading

Take a look at the core admin module Logged in users - that has got it right
Logged-in Users 123 Administration 123 Site

On 30 January 2016 at 18:32, infograf768 notifications@github.com wrote:

OK for me.


Reply to this email directly or view it on GitHub
#9030 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar jtherczeg
jtherczeg - comment - 30 Jan 2016

Actually, I also prefer (logged-in users", but thinking with the head of a translator, "logged-in users" is short in English (16 chars), while a translation may be much longer, in Hungarian for instance 28 chars, what will not look well on the status bar.

avatar MATsxm
MATsxm - comment - 30 Jan 2016

agree with both, then is it ok @brianteeman if we just use: 'Logged-in'?
we then already suppose we are talking about "Users"?

avatar brianteeman brianteeman - change - 11 Mar 2016
Category Language & Strings
avatar brianteeman brianteeman - change - 11 Mar 2016
Labels
avatar chrisdavenport
chrisdavenport - comment - 7 May 2016

Closing as "Members" is not appropriate in this context and no better term than the one currently in use has been suggested.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9030.

avatar chrisdavenport chrisdavenport - change - 7 May 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-05-07 13:28:03
Closed_By chrisdavenport
avatar chrisdavenport
chrisdavenport - comment - 7 May 2016
avatar joomla-cms-bot joomla-cms-bot - change - 7 May 2016
Labels

Add a Comment

Login with GitHub to post a comment