User tests: Successful: Unsuccessful:
Our JTable class suppose to allow developers to use column alias for the following common columns: checked_out, checked_out_time, hits (for example, in my custom database table, I can use view_count field instead of hits and use setColumnAlias to map that field with the original hits field)
However, there are places in the class, the columns name are hardcoded instead of using it's alias (if it is set). That makes the following methods checkIn, checkOut, publish, hit won't work properly if someone uses custom columns name in his database table despite that he set the alias properly.
This PR simply fix that mistakes. I also move the getColumnAlias out of the for loop in publish method, so it should has litle performance improvement, too
I think this PR just need code review from maintainers. The modification will affect check in, checkout, publish methods, so if you want to help testing this change, you can login to backend of your site, create an article, try to publish, checkin, checkout it and make sure everything still works as expected.
Status | New | ⇒ | Pending |
Labels |
Added:
?
|
Rel_Number | 0 | ⇒ | 6901 |
Relation Type | ⇒ | Pull Request for |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-28 20:27:38 |
Closed_By | ⇒ | wilsonge |
Milestone |
Added: |
Merged on review