? Success
Pull Request for # 6901

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
28 Jan 2016

PR Summary

Our JTable class suppose to allow developers to use column alias for the following common columns: checked_out, checked_out_time, hits (for example, in my custom database table, I can use view_count field instead of hits and use setColumnAlias to map that field with the original hits field)

However, there are places in the class, the columns name are hardcoded instead of using it's alias (if it is set). That makes the following methods checkIn, checkOut, publish, hit won't work properly if someone uses custom columns name in his database table despite that he set the alias properly.

This PR simply fix that mistakes. I also move the getColumnAlias out of the for loop in publish method, so it should has litle performance improvement, too

Testing instructions

I think this PR just need code review from maintainers. The modification will affect check in, checkout, publish methods, so if you want to help testing this change, you can login to backend of your site, create an article, try to publish, checkin, checkout it and make sure everything still works as expected.

avatar joomdonation joomdonation - open - 28 Jan 2016
avatar joomdonation joomdonation - change - 28 Jan 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jan 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 28 Jan 2016
Rel_Number 0 6901
Relation Type Pull Request for
avatar wilsonge wilsonge - merge - 28 Jan 2016
avatar wilsonge wilsonge - close - 28 Jan 2016
avatar wilsonge wilsonge - change - 28 Jan 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-01-28 20:27:38
Closed_By wilsonge
avatar wilsonge wilsonge - close - 28 Jan 2016
avatar wilsonge wilsonge - reference | 52d0bb6 - 28 Jan 16
avatar wilsonge wilsonge - change - 28 Jan 2016
Milestone Added:
avatar wilsonge
wilsonge - comment - 28 Jan 2016

Merged on review

Add a Comment

Login with GitHub to post a comment