[#9003] - Regression: Correcting fatal error in mod_version
- Closed
- 28 Jan 2016
- Urgent
- Build: staging
- Easy Test
- # 9003
- Diff
- infograf768:modversionerror
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Solves #9002
( ! ) Fatal error: Can't use method return value in write context in ROOT/administrator/modules/mod_version/helper.php on line 36
To test enable the administrator mod_version module, admin loads with error, patch and reload page.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Modules |
| Priority | Medium | ⇒ | Urgent |
| Easy | No | ⇒ | Yes |
Prior to PHP 5.5, empty() only supports variables
ok thanks @ggppdk.
@infograf768, since i only have a PHP 5.6.x server i can't test it but looking at the code seems fine to me.
I am using PHP 5.4.4 indeed.
Please add test OK on issues.
I have tested this item 
successfully on ea93434
Tested by code review.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9003.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-01-28 09:34:13 |
| Closed_By | ⇒ | wilsonge |
I can't replace beta 2. maybe if we get that session issue solved I can release a beta 3 with this and the session fix in
| Milestone |
Added: |
||
oh. ok
Can you add a note to the Known Issues on the announcement then ?
On 28 January 2016 at 09:35, andrepereiradasilva notifications@github.com
wrote:
oh. ok
—
Reply to this email directly or view it on GitHub
#9003 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@brianteeman, are you talking to me? or to @wilsonge ?
I have tested this item successfully on ea93434
It works Ok
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9003.
I was talking to @wilsonge
On 28 January 2016 at 09:58, Anibal Sanchez notifications@github.com
wrote:
I have tested this item [image:
ea93434
ea93434It works Ok
This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/9003
https://issues.joomla.org/tracker/joomla-cms/9003.—
Reply to this email directly or view it on GitHub
#9003 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Done. I will attempt to do beta 3 tonight - but as I didn't leave my room last night between beta 2 and J4 meeting I have a mounting list of non-joomla things to do so no guarentees
@infograf768 i can' reproduce the problem.
Admin mod version is enabled by default and i have no error.
Can you be more specific? Could it be a php specific version problem?
I tested in PHP 5.6.15. But is see in php http://php.net/manual/en/function.empty.php that empty can return fatal prior.